From: potturu venkata prasad <venkataprasad.potturu@amd.com>
To: Mark Brown <broonie@kernel.org>
Cc: "Jaroslav Kysela" <perex@perex.cz>,
alsa-devel@alsa-project.org, Vijendar.Mukunda@amd.com,
Basavaraj.Hiregoudar@amd.com, Sunil-kumar.Dommati@amd.com,
syed.sabakareem@amd.com, mario.limonciello@amd.com,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Takashi Iwai" <tiwai@suse.com>,
"Tim Crawford" <tcrawford@system76.com>,
"Attila Tőkés" <attitokes@gmail.com>,
"Techno Mooney" <techno.mooney@gmail.com>,
"Jeremy Soller" <jeremy@system76.com>,
"Malcolm Hart" <malcolm@5harts.com>,
"open list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..."
<linux-sound@vger.kernel.org>,
"open list" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ASoC: amd: yc: Fix for enabling DMIC on acp6x via _DSD entry
Date: Wed, 27 Nov 2024 23:07:00 +0530 [thread overview]
Message-ID: <3c38dc28-8de4-4b77-aaef-628711f328de@amd.com> (raw)
In-Reply-To: <7291d216-59a9-4a99-af74-8789b9426916@sirena.org.uk>
On 11/27/24 23:03, Mark Brown wrote:
> On Wed, Nov 27, 2024 at 10:34:32PM +0530, potturu venkata prasad wrote:
>> On 11/27/24 18:06, Jaroslav Kysela wrote:
>>> The logic seems wrong. The overrides code bellow won't be executed when
>>> ACPI _WOV data are not set. I think that it may cause regressions for
>>> some BIOS versions.
>>> Also, the return code should be probably -ENODEV.
>> Okay Jaroslav,
>> We will correct it and resend v2 patch.
> Given that I applied this before Jaroslav's review please send an
> incremental patch that fixes the issue.
Sorry, I missed it, will send incremental patch.
Thanks.
prev parent reply other threads:[~2024-11-27 17:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-27 11:22 [PATCH] ASoC: amd: yc: Fix for enabling DMIC on acp6x via _DSD entry Venkata Prasad Potturu
2024-11-27 12:13 ` Mark Brown
2024-11-27 12:36 ` Jaroslav Kysela
2024-11-27 17:04 ` potturu venkata prasad
2024-11-27 17:33 ` Mark Brown
2024-11-27 17:37 ` potturu venkata prasad [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3c38dc28-8de4-4b77-aaef-628711f328de@amd.com \
--to=venkataprasad.potturu@amd.com \
--cc=Basavaraj.Hiregoudar@amd.com \
--cc=Sunil-kumar.Dommati@amd.com \
--cc=Vijendar.Mukunda@amd.com \
--cc=alsa-devel@alsa-project.org \
--cc=attitokes@gmail.com \
--cc=broonie@kernel.org \
--cc=jeremy@system76.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=malcolm@5harts.com \
--cc=mario.limonciello@amd.com \
--cc=perex@perex.cz \
--cc=syed.sabakareem@amd.com \
--cc=tcrawford@system76.com \
--cc=techno.mooney@gmail.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox