Linux Sound subsystem development
 help / color / mirror / Atom feed
From: Sander Vanheule <sander@svanheule.net>
To: "Sheetal ." <sheetal@nvidia.com>,
	linux-sound@vger.kernel.org, Mark Brown	 <broonie@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
	Jaroslav Kysela <perex@perex.cz>,  Takashi Iwai <tiwai@suse.com>,
	Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter	 <jonathanh@nvidia.com>,
	Charles Keepax <ckeepax@opensource.cirrus.com>,
		linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: tegra: Fix uninitialized flat cache warning in tegra210_ahub
Date: Mon, 08 Dec 2025 21:57:01 +0100	[thread overview]
Message-ID: <3c8b0ff11a7b5bcc26c2e99b7369cb50d48621ec.camel@svanheule.net> (raw)
In-Reply-To: <20251208052040.4025612-1-sheetal@nvidia.com>

Hi,

On Mon, 2025-12-08 at 10:50 +0530, Sheetal . wrote:
> From: sheetal <sheetal@nvidia.com>
> 
> The tegra210_ahub driver started triggering a warning after commit
> e062bdfdd6ad ("regmap: warn users about uninitialized flat cache"),
> which flags drivers using REGCACHE_FLAT without register defaults.
> Since the driver omits default definitions because its registers are
> zero initialized, the following warning is shown:
> 
>   WARNING KERN tegra210-ahub 2900800.ahub: using zero-initialized flat cache,
> this may cause unexpected behavior
> 
> Switch to REGCACHE_FLAT_S which is the recommended cache type for
> sparse register maps without defaults. This cache type initializes
> entries on-demand from hardware, eliminating the warning while using
> memory efficiently.
> 
> Fixes: e062bdfdd6ad ("regmap: warn users about uninitialized flat cache")

I disagree with this tag. The commit is working as intended by giving a warning.

This device's reset state happens to match the zero-initialization of the flat
cache, so there were no issues here. An earlier version of this sparse flat
cache indicated a potential problem with another driver, so there are likely
drivers out there that do need fixing:

https://lore.kernel.org/all/a2f7e2c3-f072-40f7-a865-5693b82b636e@sirena.org.uk/


Regardless, this patch could still be material for 6.19 to avoid unneeded
warnings, but that's up to Mark.

Best,
Sander

  reply	other threads:[~2025-12-08 21:05 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-08  5:20 [PATCH] ASoC: tegra: Fix uninitialized flat cache warning in tegra210_ahub Sheetal .
2025-12-08 20:57 ` Sander Vanheule [this message]
2025-12-09  1:01   ` Mark Brown
2025-12-15 13:58 ` Mark Brown
2025-12-16 10:36   ` Sheetal .
2025-12-17 10:37     ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3c8b0ff11a7b5bcc26c2e99b7369cb50d48621ec.camel@svanheule.net \
    --to=sander@svanheule.net \
    --cc=broonie@kernel.org \
    --cc=ckeepax@opensource.cirrus.com \
    --cc=jonathanh@nvidia.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=sheetal@nvidia.com \
    --cc=thierry.reding@gmail.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox