From: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>,
Srinivas Kandagatla <srini@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>
Cc: linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/6] ASoC: qcom: audioreach: Drop unused audioreach_control_load_mix() arguments
Date: Wed, 3 Dec 2025 08:24:49 +0000 [thread overview]
Message-ID: <3cddb94b-a63d-4b75-95b7-7fd0378fda1d@oss.qualcomm.com> (raw)
In-Reply-To: <2ac6ccd1-9d35-49cf-aec6-771622e24876@oss.qualcomm.com>
On 12/3/25 8:05 AM, Krzysztof Kozlowski wrote:
> On 01/12/2025 16:21, Srinivas Kandagatla wrote:
>>
>>
>> On 11/29/25 2:02 PM, Krzysztof Kozlowski wrote:
>>> Simplify the audioreach_control_load_mix() function by removing its
>>> unused arguments.
>>
>> TBH, this is an unnecessary cleanup.
>>
>> There are 1000+ of such instances in all over the kernel, if we audit this.
>>
>> Functions will have more arguments than that gets used in the
>> implementations for various reasons, consistency, future use etc..
>>
>> I dont see any point in this type of cleanups.
>>
>
>
> Sure, no problem. Just please confirm - you mean only this patch
> dropping the arguments?
Yes please, just drop this patch.
--srini>
> Best regards,
> Krzysztof
next prev parent reply other threads:[~2025-12-03 8:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-29 14:02 [PATCH 0/6] ASoC: qcom: Constify few things in audioreach and topology Krzysztof Kozlowski
2025-11-29 14:02 ` [PATCH 1/6] ASoC: qcom: audioreach: Drop unused audioreach_control_load_mix() arguments Krzysztof Kozlowski
2025-12-01 15:21 ` Srinivas Kandagatla
2025-12-03 8:05 ` Krzysztof Kozlowski
2025-12-03 8:24 ` Srinivas Kandagatla [this message]
2025-11-29 14:02 ` [PATCH 2/6] ASoC: qcom: topology: Constify pointed topology and vendor structs Krzysztof Kozlowski
2025-11-29 14:02 ` [PATCH 3/6] ASoC: qcom: topology: Constify pointed ar control structs Krzysztof Kozlowski
2025-11-29 14:02 ` [PATCH 4/6] ASoC: qcom: topology: Constify pointed DAPM widget structs Krzysztof Kozlowski
2025-11-29 14:02 ` [PATCH 5/6] ASoC: qcom: topology: Constify pointed snd_soc_tplg_dapm_widget Krzysztof Kozlowski
2025-11-29 14:02 ` [PATCH 6/6] ASoC: qcom: audioreach: Constify function arguments Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3cddb94b-a63d-4b75-95b7-7fd0378fda1d@oss.qualcomm.com \
--to=srinivas.kandagatla@oss.qualcomm.com \
--cc=broonie@kernel.org \
--cc=krzysztof.kozlowski@oss.qualcomm.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=srini@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox