Re: [EXTERNAL] Re: [PATCH v1] Upload dsp firmware for ASUS laptop 1EB30 & 1EB31 and Update WHENCE for both

[Mario Limonciello <superm1@gmail.com>]

> Although TAS2XXX1EB30.bin and TAS2XXX1EB31.bin are both in ti/tas2781, yet it reported "does not exist".
> I have no idea why the file is there while report "does not exist". After I removed the newly-merged, no such report.

I think you forgot to git add them to the commit?

> 
> Following is the log.
> 
> root@LAPTOP-70RJ5B8Q:/usr/local/src/fw_new# make check
> Check that executables have shebangs.....................................Passed
> Forbid new submodules....................................................Passed
> Check Yaml...............................................................Passed
> Check for broken symlinks............................(no files to check)Skipped
> Detect Destroyed Symlinks................................................Passed
> shellcheck...............................................................Passed
> black....................................................................Passed
> markdownlint.............................................................Failed
> - hook id: markdownlint
> - exit code: 1
> 
> internal/modules/cjs/loader.js:818
>    throw err;
>    ^
> 
> Error: Cannot find module 'node:fs'
> Require stack:
> - /root/.cache/pre-commit/repoxl59c0uz/node_env-system/lib/node_modules/markdownlint-cli/markdownlint.js
>      at Function.Module._resolveFilename (internal/modules/cjs/loader.js:815:15)
>      at Function.Module._load (internal/modules/cjs/loader.js:667:27)
>      at Module.require (internal/modules/cjs/loader.js:887:19)
>      at require (internal/modules/cjs/helpers.js:85:18)
>      at Object.<anonymous> (/root/.cache/pre-commit/repoxl59c0uz/node_env-system/lib/node_modules/markdownlint-cli/markdownlint.js:5:12)
>      at Module._compile (internal/modules/cjs/loader.js:999:30)
>      at Object.Module._extensions..js (internal/modules/cjs/loader.js:1027:10)
>      at Module.load (internal/modules/cjs/loader.js:863:32)
>      at Function.Module._load (internal/modules/cjs/loader.js:708:14)
>      at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:60:12) {
>    code: 'MODULE_NOT_FOUND',
>    requireStack: [
>      '/root/.cache/pre-commit/repoxl59c0uz/node_env-system/lib/node_modules/markdownlint-cli/markdownlint.js'
>    ]
> }
> 

This looks like you're missing some dependencie on you system for 
markdownlint. You need nodejs v18.

If you can't install this you can skip this check when you commit by 
adding "SKIP=markdownlint" to your environment while running 'git commit'.

> Check whence.............................................................Failed
> - hook id: check-whence
> - exit code: 1
> 
> E: ti/tas2781/TAS2XXX1EB30.bin listed in WHENCE does not exist
> E: ti/tas2781/TAS2XXX1EB31.bin listed in WHENCE does not exist
> E: target ti/tas2781/TAS2XXX1EB30.bin of link TAS2XXX1EB30.bin in WHENCE does not exist
> E: target ti/tas2781/TAS2XXX1EB31.bin of link TAS2XXX1EB31.bin in WHENCE does not exist
> 

These files are missing in your commit or they have broken links. 
Double check them.

> make: *** [Makefile:10: check] Error 1
> root@LAPTOP-70RJ5B8Q:/usr/local/src/fw_new# ls ti/tas2781/TAS2XXX1* -al
> -rw-r--r-- 1 root root 35220 Sep 28 21:54 ti/tas2781/TAS2XXX1EB30.bin
> -rw-r--r-- 1 root root 35220 Sep 28 21:55 ti/tas2781/TAS2XXX1EB31.bin
> root@LAPTOP-70RJ5B8Q:/usr/local/src/fw_new#
>>
>> Thanks,