From: Krzysztof Kozlowski <krzk@kernel.org>
To: Prasad Kumpatla <quic_pkumpatl@quicinc.com>,
Fabio Estevam <festevam@gmail.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>
Cc: linux-sound@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, quic_mohsquicinc.com@qualcomm.com,
kernel@quicinc.com
Subject: Re: [PATCH v1 2/2] ASoC: sgtl5000: Introduce "mclk-rate" Property for Device Tree Configuration
Date: Mon, 16 Dec 2024 12:21:36 +0100 [thread overview]
Message-ID: <3fe71f37-8737-43ed-a2dd-1435ece375e6@kernel.org> (raw)
In-Reply-To: <20241216110341.3707-3-quic_pkumpatl@quicinc.com>
On 16/12/2024 12:03, Prasad Kumpatla wrote:
> Introduce the "mclk-rate" property, enabling the configuration of the
> Master Clock (MCLK) via the device tree. The Codec Slave supports
> a defined range of frequencies, and users can request the desired rate
> from the Master, using `clk_set_rate()`. If the property is not specified,
> the default MCLK frequency will be applied.
>
> Signed-off-by: Prasad Kumpatla <quic_pkumpatl@quicinc.com>
> ---
> sound/soc/codecs/sgtl5000.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/sound/soc/codecs/sgtl5000.c b/sound/soc/codecs/sgtl5000.c
> index 7aa89e34657e..7e134a3219c7 100644
> --- a/sound/soc/codecs/sgtl5000.c
> +++ b/sound/soc/codecs/sgtl5000.c
> @@ -1615,6 +1615,16 @@ static int sgtl5000_i2c_probe(struct i2c_client *client)
> goto disable_regs;
> }
>
> + if (!of_property_read_u32(np, "mclk-rate", &value)) {
No, NAK, you just reimplemented legacy clock-frequency property
duplicating existing assigned-clocks properties.
Best regards,
Krzysztof
prev parent reply other threads:[~2024-12-16 11:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-16 11:03 [PATCH v1 0/2] ASoC: sgtl5000: Introduce "mclk-rate" Property for Device Tree Configuration Prasad Kumpatla
2024-12-16 11:03 ` [PATCH v1 1/2] ASoC: dt-bindings: Add support for master clock frequency Prasad Kumpatla
2024-12-16 11:17 ` Fabio Estevam
2024-12-16 11:20 ` Krzysztof Kozlowski
2024-12-17 15:36 ` Rob Herring
2024-12-16 11:03 ` [PATCH v1 2/2] ASoC: sgtl5000: Introduce "mclk-rate" Property for Device Tree Configuration Prasad Kumpatla
2024-12-16 11:21 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3fe71f37-8737-43ed-a2dd-1435ece375e6@kernel.org \
--to=krzk@kernel.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@quicinc.com \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=quic_mohsquicinc.com@qualcomm.com \
--cc=quic_pkumpatl@quicinc.com \
--cc=robh@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox