From: Krzysztof Kozlowski <krzk@kernel.org>
To: Shengjiu Wang <shengjiu.wang@gmail.com>
Cc: Shengjiu Wang <shengjiu.wang@nxp.com>,
lgirdwood@gmail.com, broonie@kernel.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org,
linux-sound@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: dt-bindings: fsl,ssi: Convert to YAML
Date: Thu, 18 Apr 2024 19:14:45 +0200 [thread overview]
Message-ID: <47dea00a-79b5-452c-958d-eb56d4577119@kernel.org> (raw)
In-Reply-To: <CAA+D8ANB1v1ei6ez6KSWoXLMqk+6CvThY3qrDsqO=tHOC0DNhg@mail.gmail.com>
On 18/04/2024 05:04, Shengjiu Wang wrote:
>>> + "#sound-dai-cells":
>>> + const: 0
>>> + description: optional, some dts node didn't add it.
>>
>> The question is: is this DAI or not?
>
> Yes, it is a DAI. so, is there any issue here?
>
>>
>>> +
>>> +required:
>>> + - compatible
>>> + - reg
>>> + - interrupts
>>> + - fsl,fifo-depth
>>> +
>>> +unevaluatedProperties: false
>>
>> This must be additionalProperties:false. Use example-schema as
>> reference... unless you want to reference dai-common.yaml, but then that
>> one is missing.
>
> As it is a DAI, so I should include dai-common.yaml, right?
Yes and then unevaluated is correct.
Best regards,
Krzysztof
prev parent reply other threads:[~2024-04-18 17:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-17 9:25 [PATCH] ASoC: dt-bindings: fsl,ssi: Convert to YAML Shengjiu Wang
2024-04-17 14:16 ` Krzysztof Kozlowski
2024-04-18 3:04 ` Shengjiu Wang
2024-04-18 17:14 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47dea00a-79b5-452c-958d-eb56d4577119@kernel.org \
--to=krzk@kernel.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=robh@kernel.org \
--cc=shengjiu.wang@gmail.com \
--cc=shengjiu.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox