Re: [RFC][PATCH 0/3] ASoC: remove card->pop_time

["Péter Ujfalusi" <peter.ujfalusi@linux.intel.com>]

On 09/04/2026 22:11, Mark Brown wrote:
> On Thu, Apr 09, 2026 at 11:14:08AM +0300, Péter Ujfalusi wrote:
>> On 09/04/2026 07:36, Kuninori Morimoto wrote:
> 
>>> I'm now trying to cleanup snd_soc_card, and noticed that card->pop_time is used
>>> only from OMAP1 board-ams-delta.
> 
>> The pop_time is an amazingly good tool to debug pop noise and is mostly
>> used via the debugfs.
>> You set the pop_time to non 0 and DAPM will 'slow down' and you can
>> identify the step which produces the pop.
> 
>> Please, don't remove it!
> 
> For Morimoto-san's purposes I think it's sufficient to just make it not
> card specific so we could just have a global control in debugfs that
> applies to all cards instead.  That's likely sufficient for debugging
> use?

and I think at least the amx-delta is using the pop_time incorrectly, it
is using it as a handshake flag between the codec driver and the machine
driver and if I look back it started to to it with

fac3f5e20dce ("ASoC: don't use codec hw_write on cx20442/omap-ams-delta")
which changed it from codec->hw_write to the pop_time

f0fba2ad1b6b ("ASoC: multi-component - ASoC Multi-Component Support")
changed the original codec->control_data to codec->hw_write.

Yes, the global pop_time (card level?) is fine for debugging and the
cx20442/amx-delta needs proper handshake implementation.

-- 
Péter