From: Cezary Rojewski <cezary.rojewski@intel.com>
To: Thorsten Blum <thorsten.blum@linux.dev>
Cc: <linux-sound@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
"Liam Girdwood" <liam.r.girdwood@linux.intel.com>,
Peter Ujfalusi <peter.ujfalusi@linux.intel.com>,
Bard Liao <yung-chuan.liao@linux.intel.com>,
Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
Kai Vehmanen <kai.vehmanen@linux.intel.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>,
Mark Brown <broonie@kernel.org>,
"Jaroslav Kysela" <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Subject: Re: [PATCH 1/2] ASoC: Intel: atom: Replace deprecated strcpy in sst_slot_enum_info
Date: Wed, 12 Nov 2025 12:44:00 +0100 [thread overview]
Message-ID: <49fc19ea-4401-4f33-ad4d-5419acf6139a@intel.com> (raw)
In-Reply-To: <20251111224706.87508-2-thorsten.blum@linux.dev>
On 2025-11-11 11:47 PM, Thorsten Blum wrote:
> strcpy() is deprecated; use the safer strscpy() instead.
>
> Link: https://github.com/KSPP/linux/issues/88
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
> ---
> sound/soc/intel/atom/sst-atom-controls.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/intel/atom/sst-atom-controls.c b/sound/soc/intel/atom/sst-atom-controls.c
> index 38116c758717..799d4f0881e3 100644
> --- a/sound/soc/intel/atom/sst-atom-controls.c
> +++ b/sound/soc/intel/atom/sst-atom-controls.c
> @@ -142,7 +142,7 @@ static int sst_slot_enum_info(struct snd_kcontrol *kcontrol,
>
> if (uinfo->value.enumerated.item > e->max - 1)
> uinfo->value.enumerated.item = e->max - 1;
> - strcpy(uinfo->value.enumerated.name,
> + strscpy(uinfo->value.enumerated.name,
> e->texts[uinfo->value.enumerated.item]);
>
> return 0;
If you go for one-patch approach as suggested by me in the PATCH 2/2
review, the title should be: 'ASoC: Intel: atom: Replace strcpy() with
strscpy()'
For this patch, both for v1 and v2 (if any):
Reviewed-by: Cezary Rojewski <cezary.rojewski@intel.com>
next prev parent reply other threads:[~2025-11-12 11:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-11 22:47 [PATCH 1/2] ASoC: Intel: atom: Replace deprecated strcpy in sst_slot_enum_info Thorsten Blum
2025-11-11 22:47 ` [PATCH 2/2] ASoC: Intel: sst: Replace deprecated strcpy in sst_acpi_probe Thorsten Blum
2025-11-12 11:41 ` Cezary Rojewski
2025-11-12 11:44 ` Cezary Rojewski [this message]
2025-11-12 17:23 ` [PATCH 1/2] ASoC: Intel: atom: Replace deprecated strcpy in sst_slot_enum_info Thorsten Blum
2025-11-12 17:55 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49fc19ea-4401-4f33-ad4d-5419acf6139a@intel.com \
--to=cezary.rojewski@intel.com \
--cc=broonie@kernel.org \
--cc=kai.vehmanen@linux.intel.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=peter.ujfalusi@linux.intel.com \
--cc=pierre-louis.bossart@linux.dev \
--cc=ranjani.sridharan@linux.intel.com \
--cc=thorsten.blum@linux.dev \
--cc=tiwai@suse.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox