From: Clemens Ladisch <clemens@ladisch.de>
To: Lubomir Rintel <lkundrak@v3.sk>
Cc: alsa-devel@alsa-project.org, linux-sound@vger.kernel.org,
linux-kernel@vger.kernel.org, tiwai@suse.de
Subject: Re: [PATCH] [snd-usb-audio] Add match for JMTek USB sound card
Date: Mon, 12 Oct 2009 06:46:26 +0000 [thread overview]
Message-ID: <4AD2D0C2.40307@ladisch.de> (raw)
In-Reply-To: <1255173329-20485-1-git-send-email-lkundrak@v3.sk>
Lubomir Rintel wrote:
> Entry for JMTek LLC., SSS USB Headphone Set in the quirk table.
Please add an explaination why this entry is needed. At first glance,
this entry seems to describe a class-compliant device that should not
need a quirk.
> +/* JMTek, LLC. SSS USB Headphone Set */
> +{
> + .match_flags = USB_DEVICE_ID_MATCH_DEVICE |
> + USB_DEVICE_ID_MATCH_DEV_CLASS |
> + USB_DEVICE_ID_MATCH_INT_CLASS |
> + USB_DEVICE_ID_MATCH_INT_SUBCLASS,
> + .idVendor = 0x0c76,
> + .idProduct = 0x1605,
> + .bDeviceClass = USB_CLASS_PER_INTERFACE,
> + .bInterfaceClass = USB_CLASS_AUDIO,
> + .bInterfaceSubClass = USB_SUBCLASS_AUDIO_CONTROL
> +},
Best regards,
Clemens
next prev parent reply other threads:[~2009-10-12 6:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-10 11:15 [PATCH] [snd-usb-audio] Add match for JMTek USB sound card Lubomir Rintel
2009-10-12 6:32 ` [alsa-devel] " Takashi Iwai
2009-10-12 6:42 ` [PATCH] " Lubomir Rintel
2009-10-12 6:46 ` Takashi Iwai
2009-10-12 6:46 ` Clemens Ladisch [this message]
2009-10-12 7:18 ` [PATCH] [snd-usb-audio] " Takashi Iwai
2009-10-12 8:03 ` Lubomir Rintel
2009-10-12 8:08 ` Takashi Iwai
2009-10-18 16:37 ` Lubomir Rintel
2009-10-30 10:29 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AD2D0C2.40307@ladisch.de \
--to=clemens@ladisch.de \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=lkundrak@v3.sk \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox