From: Sameer Pujar <spujar@nvidia.com>
To: Arnd Bergmann <arnd@kernel.org>, Mark Brown <broonie@kernel.org>,
Mohan Kumar <mkumard@nvidia.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
linux-sound@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: tegra: select CONFIG_SND_SIMPLE_CARD_UTILS
Date: Fri, 19 Jul 2024 13:39:29 +0530 [thread overview]
Message-ID: <4a038fe9-fee6-4e65-a1f3-8a74cf3df922@nvidia.com> (raw)
In-Reply-To: <20240719074831.3253995-1-arnd@kernel.org>
On 19-07-2024 13:18, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> This I2S client driver now uses functions exported from a helper module
> but fails to link when the helper is disabled:
>
> ERROR: modpost: "simple_util_parse_convert" [sound/soc/tegra/snd-soc-tegra210-i2s.ko] undefined!
> ERROR: modpost: "simple_util_get_sample_fmt" [sound/soc/tegra/snd-soc-tegra210-i2s.ko] undefined!
>
> Add a Kconfig select line to ensure it's always turned on here.
>
> Fixes: 2502f8dd8c30 ("ASoC: tegra: I2S client convert formats handling")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> sound/soc/tegra/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
Thanks for the fix.
Reviewed-by: Sameer Pujar <spujar@nvidia.com>
next prev parent reply other threads:[~2024-07-19 8:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-19 7:48 [PATCH] ASoC: tegra: select CONFIG_SND_SIMPLE_CARD_UTILS Arnd Bergmann
2024-07-19 8:09 ` Sameer Pujar [this message]
2024-07-22 19:12 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4a038fe9-fee6-4e65-a1f3-8a74cf3df922@nvidia.com \
--to=spujar@nvidia.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=broonie@kernel.org \
--cc=jonathanh@nvidia.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mkumard@nvidia.com \
--cc=perex@perex.cz \
--cc=thierry.reding@gmail.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox