Re: [PATCH v4 2/2] soundwire: amd: refactor bandwidth calculation logic

["Mukunda,Vijendar" <vijendar.mukunda@amd.com>]

On 03/02/26 18:51, Pierre-Louis Bossart wrote:
> On 2/2/26 18:25, Mukunda,Vijendar wrote:
>> On 02/02/26 22:35, Pierre-Louis Bossart wrote:
>>> On 1/29/26 07:14, Vijendar Mukunda wrote:
>>>> For current platforms(ACP6.3/ACP7.0/ACP7.1/ACP7.2), AMD SoundWire manager
>>>> doesn't have banked registers for data port programming on Manager's side.
>>>> Need to use fixed block offsets, hstart & hstop for manager ports.
>>>> Earlier amd manager driver has support for 12MHz as a bus clock frequency
>>>> with frame size as 50 x 10 with fixed block offset mapping based on port
>>>> number. Got a requirement to support 6MHz bus clock frequency with
>>>> different frame shapes 50 x 10 and 125 x 2.
>>> the two frame shapes don't carry the same number of bits (500 v. 250). There's probably an additional variable at play, maybe frame rate? Or is 50x10 for 12 MHz and 125x2 for 6 MHz?
>> We need to support 12Mhz as bus clock frequency where frame rate is 48000
>> and number of bits is 500, frame shape as 50 x 10.
>> For 6Mhz bus clock frequency we need to support two different frame shapes
>> i.e number of bits as 250 with frame rate as 48000 and frame shape as
>> 125 x 2 and For second combination number of bits as 500 where frame rate
>> as 24000 and frame size as 50 x10.
>> Few SoundWire peripherals doesn't support 125 x2 frame shape for 6Mhz
>> bus clock frequency.   They have explicit requirement for the frame shape.
>> In this scenario, we will use 50 x 10 as frame shape where frame rate as 
>> 24000. Based on the platform and SoundWire topology for 6Mhz support
>> frame shape will be decided which is part of SoundWire manager DisCo
>> tables.
> Makes sense, all of the above should be added to the commit message or the code comment, specifically the 125x2 issue with non-conformant devices.
Will update the commit message and re-spin the patch series.