Re: [PATCH] ASoC: Intel: cht_bsw_rt5672: Simplify probe() with local 'dev' pointer

[Cezary Rojewski <cezary.rojewski@intel.com>]

On 2026-04-27 4:46 PM, Sachin Mokashi wrote:
> In snd_cht_mc_probe(), &pdev->dev is dereferenced repeatedly throughout
> the function. Introduce a local dev pointer
> early in the function and use it consistently in place of all open-coded
> &pdev->dev references.
> 
> It reduces repetition, improves readability, and aligns with the common
> kernel driver pattern of caching the device pointer at function entry.

One nit below but it's not a strong for v2.  For the patch:

Reviewed-by: Cezary Rojewski <cezary.rojewski@intel.com>


> @@ -450,12 +450,13 @@ static int snd_cht_mc_probe(struct platform_device *pdev)
>   	struct cht_mc_private *drv;
>   	struct snd_soc_acpi_mach *mach = pdev->dev.platform_data;
>   	const char *platform_name;
> +	struct device *dev = &pdev->dev;

Weird location for this declaration. Why in the middle of nowhere?

>   	struct acpi_device *adev;
>   	bool sof_parent;
>   	int dai_index = 0;
>   	int i;