From: Bo Shen <voice.shen@atmel.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: linux-sound@vger.kernel.org, alsa-devel@alsa-project.org,
nicolas.ferre@atmel.com, jm.lin@atmel.com
Subject: Re: [PATCH 3/3] i2c: change the id to let the i2c-gpio work
Date: Fri, 12 Oct 2012 01:53:21 +0000 [thread overview]
Message-ID: <50777811.8020808@atmel.com> (raw)
In-Reply-To: <20121011071140.GA11726@opensource.wolfsonmicro.com>
Hi Mark,
On 10/11/2012 15:11, Mark Brown wrote:
> On Thu, Oct 11, 2012 at 10:38:17AM +0800, Bo Shen wrote:
>
>> static struct platform_device at91sam9260_twi_device = {
>> .name = "i2c-gpio",
>> - .id = -1,
>> + .id = 0,
>> .dev.platform_data = &pdata,
>> };
>
> Why would this have any effect on the operation of the i2c-gpio driver?
> This suggests i2c-gpio is buggy.
This cause i2c devices can not register to the i2c bus which the device
want.
I will send this patch to i2c maintainer.
Thanks
BR,
Bo Shen
prev parent reply other threads:[~2012-10-12 1:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-11 2:38 [PATCH 0/3] Convert to use snd_soc_register_card() Bo Shen
2012-10-11 2:38 ` [PATCH 1/3] ASoC: sam9g20-wm8731: convert " Bo Shen
2012-10-17 13:52 ` Mark Brown
2012-10-11 2:38 ` [PATCH 2/3] ASoC: sam9g20: using platform device for audio part Bo Shen
2012-10-17 13:53 ` Mark Brown
2012-10-11 2:38 ` [PATCH 3/3] i2c: change the id to let the i2c-gpio work Bo Shen
2012-10-11 7:11 ` Mark Brown
2012-10-12 1:53 ` Bo Shen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50777811.8020808@atmel.com \
--to=voice.shen@atmel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=jm.lin@atmel.com \
--cc=linux-sound@vger.kernel.org \
--cc=nicolas.ferre@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox