From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lars-Peter Clausen Date: Wed, 03 Jul 2013 08:08:08 +0000 Subject: Re: [alsa-devel] [PATCH 2/2] ASoC: atmel-pcm: use generic dmaengine framework Message-Id: <51D3DBE8.4090407@metafoo.de> List-Id: References: <1372755849-19546-1-git-send-email-voice.shen@atmel.com> <1372755849-19546-3-git-send-email-voice.shen@atmel.com> <51D2F306.7040603@metafoo.de> <51D37F87.2010008@atmel.com> <51D3D482.1050100@metafoo.de> <51D3D969.1060308@atmel.com> In-Reply-To: <51D3D969.1060308@atmel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Bo Shen Cc: Mark Brown , alsa-devel@alsa-project.org, richard.genoud@gmail.com, Nicolas Ferre , linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org On 07/03/2013 09:57 AM, Bo Shen wrote: > Hi Lars, > > On 7/3/2013 15:36, Lars-Peter Clausen wrote: >>>>> + slave_config->dst_addr = (dma_addr_t)ssc->phybase + SSC_THR; >>>> >>[...] >>>>> >>>+ slave_config->src_addr = (dma_addr_t)ssc->phybase + SSC_RHR; >>>> >> >>>> >>Change the type of phybase to dma_addr_t >>> > >>> >It should be: >>> >slave_config->dst_addr = (dma_addr_t)(ssc->phybase + SSC_THR); >>> >slave_config->src_addr = (dma_addr_t)(ssc->phybase + SSC_RHR); >> The type of phybase in the ssc_device struct should be changed from >> resource_size_t to dma_addr_t. > > Actually, the phybase in ssc_device structure is resource_size_t which used to > access the ssc device register. > Here, we use ssc register as dma source address or destination address, so we > convert it to dma_addr_t type. So, not need to change, am I right? Isn't 'regs' used to access the registers? As far as I can see phybase is only used in the audio DMA driver. - Lars