From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lars-Peter Clausen Date: Wed, 03 Jul 2013 09:01:49 +0000 Subject: Re: [v2 0/5] ASoC: atmel-pcm: align with generic dmaengine framwork Message-Id: <51D3E87D.6040203@metafoo.de> List-Id: References: <1372840680-2253-1-git-send-email-voice.shen@atmel.com> In-Reply-To: <1372840680-2253-1-git-send-email-voice.shen@atmel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Bo Shen Cc: alsa-devel@alsa-project.org, richard.genoud@gmail.com, Nicolas Ferre , linux-sound@vger.kernel.org, Mark Brown , linux-arm-kernel@lists.infradead.org On 07/03/2013 10:37 AM, Bo Shen wrote: > This patch set is based on linux next-20130701 > > mainly implement > - move set dma data from hw_params to startup callback to avoid memory leak > - align atmel pcm with generic dmaenigne framwork > Whole series looks good to me. Although the DMA driver still references the ssc struct, but that can be fixed later. FWIW, Reviewed-by: Lars-Peter Clausen > Bo Shen (5): > ASoC: atmel_ssc_dai: move set dma data to startup callback > ASoC: atmel_ssc_dai: add error mask define > ASoC: atmel-pcm-dma: move prepare for dma to dai prepare > ARM: atmel-ssc: change phybase type to dma_addr_t > ASoC: atmel-pcm: use generic dmaengine framework > > include/linux/atmel-ssc.h | 2 +- > sound/soc/atmel/Kconfig | 1 + > sound/soc/atmel/atmel-pcm-dma.c | 118 ++++++--------------------------------- > sound/soc/atmel/atmel_ssc_dai.c | 36 ++++++------ > 4 files changed, 37 insertions(+), 120 deletions(-) >