Re: [PATCH 1/2] ASoC: atmel: sam9x5_wm8731: fix oops when unload module

Bo Shen
2013-11-27T01:13:29Z

Hi Richard,

On 11/26/2013 07:32 PM, Richard Genoud wrote:
> 2013/11/26 Bo Shen <voice.shen@atmel.com>:
>> As the priv is not assigned to card->drvdata, it is NULL, so when
>> unload module, it will cause NULL pointer oops.
>> Assign priv to card->drvdata to fix this issue.
>>
>> Signed-off-by: Bo Shen <voice.shen@atmel.com>
>> ---
>> sound/soc/atmel/sam9x5_wm8731.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/sound/soc/atmel/sam9x5_wm8731.c b/sound/soc/atmel/sam9x5_wm8731.c
>> index 992ae38..6dc33ac 100644
>> --- a/sound/soc/atmel/sam9x5_wm8731.c
>> +++ b/sound/soc/atmel/sam9x5_wm8731.c
>> @@ -99,6 +99,7 @@ static int sam9x5_wm8731_driver_probe(struct platform_device *pdev)
>>
>> card->dev = &pdev->dev;
>> card->owner = THIS_MODULE;
>> + card->drvdata = priv;
>> card->dai_link = dai;
>> card->num_links = 1;
>> card->dapm_widgets = sam9x5_dapm_widgets;
>> --
>> 1.7.9.5
>>
> There's no oops any more !
>
> Tested-by: Richard Genoud <richard.genoud@gmail.com>
>
> This should also go in -stable don't you think ?

After this patch go into mainline tree, I think we can ask it to go in
-stable tree.

> Maybe it's a bug on my kernel, but did you try to reload the module
> and play something ?

When we reload the module, as the codec is not configured outside, so it
use default value, the 'Output Mixer HiFi Playback Switch' is in off
state.If you want to play something, you need make it in on state.
Please take the following command as a reference:
--->8---
amixer cset numid\x14,iface=MIXER,name='Output Mixer HiFi Playback Switch' on
---8<---

> On my board once I unload/reload it, there's no sound comming out
> (at least, it's better than a oops ! :) )
>
> Richard.
>

Best Regards,
Bo Shen