public inbox for linux-sound@vger.kernel.org
 help / color / mirror / Atom feed
From: Nicolas Ferre <nicolas.ferre@atmel.com>
To: Bo Shen <voice.shen@atmel.com>,
	broonie@kernel.org, alsa-devel@alsa-project.org
Cc: plagnioj@jcrosoft.com, richard.genoud@gmail.com,
	linux-sound@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [Patch v2 2/2] ASoC: atmel: sam9x5_wm8731: remove platform_set_drvdata
Date: Mon, 09 Dec 2013 10:20:05 +0000	[thread overview]
Message-ID: <52A59955.8000100@atmel.com> (raw)
In-Reply-To: <1385546710-11308-2-git-send-email-voice.shen@atmel.com>

On 27/11/2013 11:05, Bo Shen :
> When call snd_soc_register_card, it will set driver data to this
> device through dev_set_drvdata, then in driver, no need to call
> platform_set_drvdata again, so remove it.
>
> Signed-off-by: Bo Shen <voice.shen@atmel.com>
> ---
> Change in v2:
>    - NONE

Hi Mark,

It seems that this patch has not been applied to your "next" branch (aka 
ping)...

BTW, it seems that we also collected this tag:
Tested-by: Richard Genoud <richard.genoud@gmail.com>

Bye,

> ---
>   sound/soc/atmel/sam9x5_wm8731.c |    2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/sound/soc/atmel/sam9x5_wm8731.c b/sound/soc/atmel/sam9x5_wm8731.c
> index 1b37228..ce9cd29 100644
> --- a/sound/soc/atmel/sam9x5_wm8731.c
> +++ b/sound/soc/atmel/sam9x5_wm8731.c
> @@ -155,8 +155,6 @@ static int sam9x5_wm8731_driver_probe(struct platform_device *pdev)
>   	of_node_put(codec_np);
>   	of_node_put(cpu_np);
>
> -	platform_set_drvdata(pdev, card);
> -
>   	ret = snd_soc_register_card(card);
>   	if (ret) {
>   		dev_err(&pdev->dev,
>


-- 
Nicolas Ferre

  reply	other threads:[~2013-12-09 10:20 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-27 10:05 [Patch v2 1/2] ASoC: atmel: sam9x5_wm8731: fix oops when unload module Bo Shen
2013-11-27 10:05 ` [Patch v2 2/2] ASoC: atmel: sam9x5_wm8731: remove platform_set_drvdata Bo Shen
2013-12-09 10:20   ` Nicolas Ferre [this message]
2013-12-09 16:58     ` Mark Brown
2013-12-18  6:55   ` [RESEND PATCH " Bo Shen
2013-12-31 12:27   ` [Patch " Mark Brown
2013-11-27 15:50 ` [Patch v2 1/2] ASoC: atmel: sam9x5_wm8731: fix oops when unload module Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52A59955.8000100@atmel.com \
    --to=nicolas.ferre@atmel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=plagnioj@jcrosoft.com \
    --cc=richard.genoud@gmail.com \
    --cc=voice.shen@atmel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox