From: Mark Brown <broonie@kernel.org>
To: Marco Crivellari <marco.crivellari@suse.com>
Cc: linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org,
Tejun Heo <tj@kernel.org>, Lai Jiangshan <jiangshanlai@gmail.com>,
Frederic Weisbecker <frederic@kernel.org>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Michal Hocko <mhocko@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>
Subject: Re: [PATCH 2/2] ASoC: replace use of system_wq with system_percpu_wq
Date: Fri, 5 Sep 2025 11:54:47 +0100 [thread overview]
Message-ID: <54446af3-9ca5-4932-a3fd-e44185751dda@sirena.org.uk> (raw)
In-Reply-To: <20250905091016.109428-3-marco.crivellari@suse.com>
[-- Attachment #1: Type: text/plain, Size: 539 bytes --]
On Fri, Sep 05, 2025 at 11:10:16AM +0200, Marco Crivellari wrote:
> +++ b/sound/soc/codecs/aw88081.c
> @@ -779,7 +779,7 @@ static void aw88081_start(struct aw88081 *aw88081, bool sync_start)
> if (sync_start == AW88081_SYNC_START)
> aw88081_start_pa(aw88081);
> else
> - queue_delayed_work(system_wq,
> + queue_delayed_work(system_percpu_wq,
> &aw88081->start_work,
> AW88081_START_WORK_DELAY_MS);
> }
I can't tell why you're putting all these onto the percpu workqeue, I
would be astonished if any of the users cared.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2025-09-05 10:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-05 9:10 [PATCH 0/2] sound: soc: replace wq users and add WQ_PERCPU to alloc_workqueue() users Marco Crivellari
2025-09-05 9:10 ` [PATCH 1/2] ASoC: replace use of system_unbound_wq with system_dfl_wq Marco Crivellari
2025-09-05 9:10 ` [PATCH 2/2] ASoC: replace use of system_wq with system_percpu_wq Marco Crivellari
2025-09-05 10:54 ` Mark Brown [this message]
2025-09-05 16:00 ` Marco Crivellari
2025-09-05 16:05 ` Mark Brown
2025-09-08 14:52 ` Marco Crivellari
2025-09-08 15:19 ` Mark Brown
2025-09-05 13:32 ` (subset) [PATCH 0/2] sound: soc: replace wq users and add WQ_PERCPU to alloc_workqueue() users Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54446af3-9ca5-4932-a3fd-e44185751dda@sirena.org.uk \
--to=broonie@kernel.org \
--cc=bigeasy@linutronix.de \
--cc=frederic@kernel.org \
--cc=jiangshanlai@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=marco.crivellari@suse.com \
--cc=mhocko@suse.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox