Re: [PATCH v2 1/3] ASoC: codecs: wm8904: add dt ids table

Mark Brown
2015-01-26T16:42:29Z

[-- Attachment #1: Type: text/plain, Size: 1074 bytes --]

On Mon, Jan 26, 2015 at 04:24:38PM +0100, Nicolas Ferre wrote:
> Le 16/01/2015 02:17, Bo Shen a écrit :

> >> Does this end up in the i2c_driver_id driver data or do we need some
> >> extra code when devtype is assigned to check for an of_node and look at
> >> the DT data instead? That certainly used to be the case...

> > At the beginning I think as the same as you, and also add the code to
> > get the data as I do in <drivers/misc/atmel-ssc.c>. However, as I
> > remember, I2C seems only use the compatible string after the comma, that
> > means only for "wlf,wm8904", it uses "wm8904" to match. So, I remove all
> > the code I added, and just keep these, and it can get the device type
> > correctly.

> > So, when I submit the patch and keep the code as simple as possible.

> I don't understand what's keeping this patch from being applied. Voice,
> do you mind re-sending?

I need to convince myself that the above actually works and is doing the
right thing; the above explanation sounds like if it works it might be
relying on a bug.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]