Re: [PATCH] ASoC: SOF: Intel: hda-sdw-bpt: fix SND_SOF_SOF_HDA_SDW_BPT dependencies

["Liao, Bard" <yung-chuan.liao@linux.intel.com>]

On 8/6/2025 12:04 AM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> The hda-sdw-bpt code links against the soundwire driver, but that fails when
> trying to link from built-in code into loadable module:
> 
> x86_64-linux-ld: vmlinux.o: in function `intel_ace2x_bpt_close_stream.isra.0':
> intel_ace2x.c:(.text+0x137a531): undefined reference to `hda_sdw_bpt_close'
> x86_64-linux-ld: vmlinux.o: in function `intel_ace2x_bpt_send_async':
> intel_ace2x.c:(.text+0x137aa45): undefined reference to `hda_sdw_bpt_open'
> x86_64-linux-ld: intel_ace2x.c:(.text+0x137ab67): undefined reference to `hda_sdw_bpt_close'
> x86_64-linux-ld: intel_ace2x.c:(.text+0x137ac30): undefined reference to `hda_sdw_bpt_send_async'
> x86_64-linux-ld: vmlinux.o: in function `intel_ace2x_bpt_wait':
> intel_ace2x.c:(.text+0x137aced): undefined reference to `hda_sdw_bpt_wait'
> 
> Ensure that both SOUNDWIRE_INTEL and SND_SOF_SOF_HDA_SDW_BPT are selected
> at the same time by SND_SOC_SOF_INTEL_LNL, and that this happens even if
> SND_SOC_SOF_INTEL_SOUNDWIRE is a loadable module but SND_SOC_SOF_INTEL_LNL
> is built-in.
> 
> This follows the same logic as commit c5a61db9bf89 ("ASoC: SOF: fix
> intel-soundwire link failure").
> 
> Fixes: 5d5cb86fb46e ("ASoC: SOF: Intel: hda-sdw-bpt: add helpers for SoundWire BPT DMA")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>

> ---
>  sound/soc/sof/intel/Kconfig | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/sound/soc/sof/intel/Kconfig b/sound/soc/sof/intel/Kconfig
> index 7e92aa2f7e39..9722ae43e87c 100644
> --- a/sound/soc/sof/intel/Kconfig
> +++ b/sound/soc/sof/intel/Kconfig
> @@ -272,9 +272,10 @@ config SND_SOC_SOF_METEORLAKE
>  
>  config SND_SOC_SOF_INTEL_LNL
>  	tristate
> +	select SOUNDWIRE_INTEL if SND_SOC_SOF_INTEL_SOUNDWIRE != n
>  	select SND_SOC_SOF_HDA_GENERIC
>  	select SND_SOC_SOF_INTEL_SOUNDWIRE_LINK_BASELINE
> -	select SND_SOF_SOF_HDA_SDW_BPT if SND_SOC_SOF_INTEL_SOUNDWIRE
> +	select SND_SOF_SOF_HDA_SDW_BPT if SND_SOC_SOF_INTEL_SOUNDWIRE != n
>  	select SND_SOC_SOF_IPC4
>  	select SND_SOC_SOF_INTEL_MTL
>