From: "Péter Ujfalusi" <peter.ujfalusi@gmail.com>
To: Primoz Fiser <primoz.fiser@norik.com>,
Jarkko Nikula <jarkko.nikula@bitmer.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
alsa-devel@alsa-project.org, linux-omap@vger.kernel.org,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: upstream@lists.phytec.de
Subject: Re: [PATCH v2] ASoC: ti: omap-hdmi: Fix too long driver name
Date: Mon, 10 Jun 2024 17:46:43 +0300 [thread overview]
Message-ID: <605944ac-6dfa-4620-84b6-392665cdc05d@gmail.com> (raw)
In-Reply-To: <20240610125847.773394-1-primoz.fiser@norik.com>
Hi,
On 6/10/24 3:58 PM, Primoz Fiser wrote:
> Set driver name to "HDMI". This simplifies the code and gets rid of
> the following error messages:
>
> ASoC: driver name too long 'HDMI 58040000.encoder' -> 'HDMI_58040000_e'
Thank you for the update,
Acked-by: Peter Ujfalusi <peter.ujfalusi@gmail.com>
> Signed-off-by: Primoz Fiser <primoz.fiser@norik.com>
> ---
> Changes in v2:
> - use "HDMI" instead of DRV_NAME (requested)
>
> sound/soc/ti/omap-hdmi.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/sound/soc/ti/omap-hdmi.c b/sound/soc/ti/omap-hdmi.c
> index 639bc83f4263..cf43ac19c4a6 100644
> --- a/sound/soc/ti/omap-hdmi.c
> +++ b/sound/soc/ti/omap-hdmi.c
> @@ -354,11 +354,7 @@ static int omap_hdmi_audio_probe(struct platform_device *pdev)
> if (!card)
> return -ENOMEM;
>
> - card->name = devm_kasprintf(dev, GFP_KERNEL,
> - "HDMI %s", dev_name(ad->dssdev));
> - if (!card->name)
> - return -ENOMEM;
> -
> + card->name = "HDMI";
> card->owner = THIS_MODULE;
> card->dai_link =
> devm_kzalloc(dev, sizeof(*(card->dai_link)), GFP_KERNEL);
--
Péter
next prev parent reply other threads:[~2024-06-10 14:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-10 12:58 [PATCH v2] ASoC: ti: omap-hdmi: Fix too long driver name Primoz Fiser
2024-06-10 14:46 ` Péter Ujfalusi [this message]
2024-06-12 17:25 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=605944ac-6dfa-4620-84b6-392665cdc05d@gmail.com \
--to=peter.ujfalusi@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=jarkko.nikula@bitmer.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=primoz.fiser@norik.com \
--cc=tiwai@suse.com \
--cc=upstream@lists.phytec.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox