From: "Csókás Bence" <csokas.bence@prolan.hu>
To: Mark Brown <broonie@kernel.org>
Cc: <linux-sound@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-sunxi@lists.linux.dev>, <linux-kernel@vger.kernel.org>,
Mesih Kilinc <mesihkilinc@gmail.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Samuel Holland <samuel@sholland.org>
Subject: Re: [PATCH v6 3/5] ASoC: sun4i-codec: Add support for Allwinner suniv F1C100s
Date: Wed, 27 Nov 2024 08:12:11 +0100 [thread overview]
Message-ID: <60f52d54-da36-4223-9063-b833451781ea@prolan.hu> (raw)
In-Reply-To: <d0ecce33-25e2-4711-8311-7788c77b7d2d@sirena.org.uk>
Hi,
On 2024. 11. 26. 13:18, Mark Brown wrote:
> On Sat, Nov 23, 2024 at 01:39:02PM +0100, Csókás, Bence wrote:
>
>> Signed-off-by: Csókás, Bence <csokas.bence@prolan.hu>
>
> When you write your signoffs like this with the , but no "" (like in
> your From:) it confuses software and causes everything after the , to
> get deleted. Probably just including the quotes is the best option to
> match the email header.
Git handles it fine since 2.46, before that there was some weirdness in
send-email not adding it to the Cc: correctly, but git am & co. worked
fine. b4 still has issues with it unfortunately.
Link: https://github.com/mricon/b4/issues/50
However, the real problem I think is that git format-patch doesn't add
the quotes. What's worse, you'll have a real hard time trying to git
config --global user.name "a quoted string". Git tries *really* hard to
remove surrounding quotation (and is further aided by the shell). I'll
see what I can do.
Bence
next prev parent reply other threads:[~2024-11-27 7:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-23 12:38 [PATCH v6 0/3] Add support for codec of F1C100s Csókás, Bence
2024-11-23 12:38 ` [PATCH v6 1/5] ASoC: sun4i-codec: Add DMA Max Burst field Csókás, Bence
2024-11-23 12:39 ` [PATCH v6 2/5] dt-bindings: sound: Add Allwinner suniv F1C100s Audio Codec Csókás, Bence
2024-11-23 16:22 ` Krzysztof Kozlowski
2024-11-23 22:09 ` Csókás Bence
2024-11-25 14:20 ` Rob Herring (Arm)
2024-11-23 12:39 ` [PATCH v6 3/5] ASoC: sun4i-codec: Add support for Allwinner suniv F1C100s Csókás, Bence
2024-11-26 12:18 ` Mark Brown
2024-11-27 7:12 ` Csókás Bence [this message]
2024-12-03 17:50 ` (subset) [PATCH v6 0/3] Add support for codec of F1C100s Mark Brown
2024-12-05 14:25 ` Chen-Yu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=60f52d54-da36-4223-9063-b833451781ea@prolan.hu \
--to=csokas.bence@prolan.hu \
--cc=broonie@kernel.org \
--cc=jernej.skrabec@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=mesihkilinc@gmail.com \
--cc=perex@perex.cz \
--cc=samuel@sholland.org \
--cc=tiwai@suse.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox