Linux Sound subsystem development
 help / color / mirror / Atom feed
From: Cezary Rojewski <cezary.rojewski@intel.com>
To: <phucduc.bui@gmail.com>
Cc: <linux-kernel@vger.kernel.org>, <linux-sound@vger.kernel.org>,
	Mark Brown <broonie@kernel.org>, Sen Wang <sen@ti.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	Jarkko Nikula <jarkko.nikula@bitmer.com>,
	"Christophe JAILLET" <christophe.jaillet@wanadoo.fr>,
	<linux-omap@vger.kernel.org>
Subject: Re: [PATCH v2 07/10] ASoC: ti: omap-hdmi: Use dev_err_probe() for error handling
Date: Thu, 16 Jul 2026 11:28:57 +0200	[thread overview]
Message-ID: <61bfa6e4-d8b7-4bf0-84f2-173384c690ea@intel.com> (raw)
In-Reply-To: <20260716090829.72082-8-phucduc.bui@gmail.com>

On 7/16/2026 11:08 AM, phucduc.bui@gmail.com wrote:
> From: bui duc phuc <phucduc.bui@gmail.com>
> 
> Replace dev_err() with dev_err_probe() when reporting
> devm_snd_soc_register_card() failures. This suppresses
> unnecessary log messages for deferred probe errors.
> 
> Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>
> ---
>   sound/soc/ti/omap-hdmi.c | 6 ++----
>   1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/sound/soc/ti/omap-hdmi.c b/sound/soc/ti/omap-hdmi.c
> index e60f5b483fc5..72114965c37d 100644
> --- a/sound/soc/ti/omap-hdmi.c
> +++ b/sound/soc/ti/omap-hdmi.c
> @@ -375,10 +375,8 @@ static int omap_hdmi_audio_probe(struct platform_device *pdev)
>   	card->dev = dev;
>   
>   	ret = devm_snd_soc_register_card(dev, card);
> -	if (ret) {
> -		dev_err(dev, "snd_soc_register_card failed (%d)\n", ret);
> -		return ret;
> -	}
> +	if (ret)
> +		return dev_err_probe(dev, ret, "snd_soc_register_card failed\n");

Some patches have '()' some do not.  I'd expect all the patches updated 
as per Christophe's review.

>   
>   	ad->card = card;
>   	snd_soc_card_set_drvdata(card, ad);


  reply	other threads:[~2026-07-16  9:29 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-16  9:08 [PATCH v2 00/10] ASoC: ti: Improve probe error handling phucduc.bui
2026-07-16  9:08 ` [PATCH v2 01/10] ASoC: ti: ams-delta: Use dev_err_probe() for " phucduc.bui
2026-07-16  9:08 ` [PATCH v2 02/10] ASoC: ti: davinci-evm: " phucduc.bui
2026-07-16  9:08 ` [PATCH v2 03/10] ASoC: ti: j721e-evm: Return the original error from card name parsing phucduc.bui
2026-07-16  9:08 ` [PATCH v2 04/10] ASoC: ti: omap-abe-twl6040: Preserve error code and drop redundant log phucduc.bui
2026-07-16  9:08 ` [PATCH v2 05/10] ASoC: ti: omap-abe-twl6040: Use dev_err_probe() for error handling phucduc.bui
2026-07-16  9:08 ` [PATCH v2 06/10] ASoC: ti: omap-dmic: " phucduc.bui
2026-07-16  9:08 ` [PATCH v2 07/10] ASoC: ti: omap-hdmi: " phucduc.bui
2026-07-16  9:28   ` Cezary Rojewski [this message]
2026-07-16 10:11     ` Bui Duc Phuc
2026-07-16  9:08 ` [PATCH v2 08/10] ASoC: ti: omap-twl4030: Return the original error code phucduc.bui
2026-07-16  9:08 ` [PATCH v2 09/10] ASoC: ti: omap-twl4030: Use dev_err_probe() for error handling phucduc.bui
2026-07-16  9:08 ` [PATCH v2 10/10] ASoC: ti: rx51: " phucduc.bui
2026-07-16 10:19   ` Cezary Rojewski
2026-07-16 10:41     ` Bui Duc Phuc
2026-07-16 11:15       ` Cezary Rojewski
2026-07-16 12:14         ` Bui Duc Phuc

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=61bfa6e4-d8b7-4bf0-84f2-173384c690ea@intel.com \
    --to=cezary.rojewski@intel.com \
    --cc=broonie@kernel.org \
    --cc=christophe.jaillet@wanadoo.fr \
    --cc=jarkko.nikula@bitmer.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=phucduc.bui@gmail.com \
    --cc=sen@ti.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox