From: Richard Fitzgerald <rf@opensource.cirrus.com>
To: broonie@kernel.org
Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
patches@opensource.cirrus.com
Subject: Re: [PATCH] ASoC: cs35l56: Fix hibernate write in runtime resume error path
Date: Wed, 29 Apr 2026 11:45:01 +0100 [thread overview]
Message-ID: <65d84c36-67d0-4769-9ce4-7ebce10f6ba9@opensource.cirrus.com> (raw)
In-Reply-To: <20260429104156.2436987-1-rf@opensource.cirrus.com>
On 29/04/2026 11:41 am, Richard Fitzgerald wrote:
> The error path of cs35l56_runtime_resume_common() should only write
> the hibernation sequence if can_hibernate is true.
>
> Something has already gone badly wrong if we ever reach the error
> path. But triggering hibernate on hardware that does not support it
> is likely to make the situation unrecoverable without a full reboot
> necause there might not be any hardware signal to exit hibernate.
>
Aargh. The typo that I didn't notice until I'd sent the email.
Will fix this in a V2.
prev parent reply other threads:[~2026-04-29 10:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-29 10:41 [PATCH] ASoC: cs35l56: Fix hibernate write in runtime resume error path Richard Fitzgerald
2026-04-29 10:45 ` Richard Fitzgerald [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=65d84c36-67d0-4769-9ce4-7ebce10f6ba9@opensource.cirrus.com \
--to=rf@opensource.cirrus.com \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox