Linux Sound subsystem development
 help / color / mirror / Atom feed
From: ALOK TIWARI <alok.a.tiwari@oracle.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: perex@perex.cz, tiwai@suse.com, phasta@kernel.org,
	linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [External] : Re: [BUG] ALSA: intel8x: Why incorrect codec index used setting ICH_DI2L SDIN
Date: Fri, 20 Jun 2025 00:56:53 +0530	[thread overview]
Message-ID: <668f9127-25e2-418e-beb6-79ff96706914@oracle.com> (raw)
In-Reply-To: <aFQvEYdQfiJn-29o@smile.fi.intel.com>



On 6/19/2025 9:08 PM, Andy Shevchenko wrote:
> On Wed, Jun 18, 2025 at 12:19:21PM -0700, Alok Tiwari wrote:
>> Correct the index to use codec[i] to match the loop iteration, not codec[1].
>>
>> Is this a mistake or intentional?
> 
> You marked it as a BUG in the Subject, can you elaborate more, please?
> 

I should have mark this as a query.
Why is the value 1 hardcoded here in the codec?

tmp |= chip->ac97_sdin[pcm->r[0].codec[1]->num] << ICH_DI2L_SHIFT;

https://web.git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/tree/sound/pci/intel8x0.c#n2252


Thanks,
Alok

  reply	other threads:[~2025-06-19 19:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-18 19:19 [BUG] ALSA: intel8x: Why incorrect codec index used setting ICH_DI2L SDIN Alok Tiwari
2025-06-19 15:38 ` Andy Shevchenko
2025-06-19 19:26   ` ALOK TIWARI [this message]
2025-06-20  8:11     ` [External] : " Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=668f9127-25e2-418e-beb6-79ff96706914@oracle.com \
    --to=alok.a.tiwari@oracle.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=phasta@kernel.org \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox