From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Ajay Kumar Nandam <ajay.nandam@oss.qualcomm.com>,
Srinivas Kandagatla <srini@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>
Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-sound@vger.kernel.org
Subject: Re: [PATCH v3 3/3] ASoC: codecs: lpass-wsa-macro: Use devm_clk_hw_register() for MCLK output
Date: Mon, 11 May 2026 13:11:09 +0200 [thread overview]
Message-ID: <66d8dd2e-05f8-4f58-bfb4-fd290dde1ebe@oss.qualcomm.com> (raw)
In-Reply-To: <20260508113503.3550647-4-ajay.nandam@oss.qualcomm.com>
On 5/8/26 1:35 PM, Ajay Kumar Nandam wrote:
> The WSA macro driver registers the MCLK output clock using
> clk_hw_register(), but does not explicitly unregister it in the remove
> path or on probe failure.
>
> Switch to devm_clk_hw_register() to make the registration resource-managed
> so the clk_hw is automatically unregistered when the device is unbound or
> probe fails. This avoids lifetime and cleanup issues and simplifies error
> handling.
>
> No functional change intended.
This is a bit of a semantic argument, but the driver will now behave
differently, since as you explained above, .remove does not currently
unregister the clock (but devres will now do that)
> Signed-off-by: Ajay Kumar Nandam <ajay.nandam@oss.qualcomm.com>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
prev parent reply other threads:[~2026-05-11 11:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-08 11:35 [PATCH v3 0/3] ASoC: qcom: lpass: Switch VA/WSA macros to PM clock framework Ajay Kumar Nandam
2026-05-08 11:35 ` [PATCH v3 1/3] ASoC: codecs: lpass-wsa-macro: Switch to PM clock framework for runtime PM Ajay Kumar Nandam
2026-05-11 11:09 ` Konrad Dybcio
2026-05-08 11:35 ` [PATCH v3 2/3] ASoC: codecs: lpass-va-macro: " Ajay Kumar Nandam
2026-05-08 11:35 ` [PATCH v3 3/3] ASoC: codecs: lpass-wsa-macro: Use devm_clk_hw_register() for MCLK output Ajay Kumar Nandam
2026-05-11 11:11 ` Konrad Dybcio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=66d8dd2e-05f8-4f58-bfb4-fd290dde1ebe@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=ajay.nandam@oss.qualcomm.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=srini@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox