From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CDF412209F; Tue, 21 May 2024 09:04:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716282296; cv=none; b=ejw/J/AkbHytPyW4PmhUXtZyHJCG3sU2rskS0sMkwqp3rngxsCe6f1DxZ/NOBKa8IQKOJiHlK9XIEhIyl6f0lfONQNjr4FMN7bMpGcJCcA4oT75KjoLHRR1KAt+S42XGwH+E70WEYLjsowwVgNw/aeD0PbfMO7sSr1dWjj3GMa4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716282296; c=relaxed/simple; bh=Fyo1MJcuF94YoHNRRQ/5sBEEN0ct+O/7ZaeMoc0v3WA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=EyRE7gQUJCnZ2KU26OaN4FhbQcl1g2nP1KGA6cjQ8Gd3XjKIdp45WfWJWvE8rvNfPNZQRWZ/LQCVp42gQ1xQI5Drsl6+P42vgyIqelKwM3JChmEpcAlAF04dau4qO2AS+EOFB35np3l4Jio5Z76qZz1Q+STo/9N5PxuJgYFqxHM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Qk49nriR; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Qk49nriR" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A7C92C2BD11; Tue, 21 May 2024 09:04:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1716282296; bh=Fyo1MJcuF94YoHNRRQ/5sBEEN0ct+O/7ZaeMoc0v3WA=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Qk49nriRU+zDbVHXmZD8vdLcGTi3K/henx+dAf6+H8xARBbLFiEldkAFammQRnEuQ IX3Nm/Z6uEvWaqO25jatU9Woq0SMMsH1O0MAG6wKspkW0Uufsls+UhhbkFUFtOS+vs O0GlzLqdusGaLSo68g645Lj9+d0RfHLzKY3UxGt5z8kubJZnVD+dhO745qBbF+1/c/ WagC/SscHg8p6GO3Aiimbh0mlAbhpWLH6upJ+r7+4hAF0cgN5BLL1EmfQZ979EOZaf Y6V625/rL9ZThgBbchPoYfmF+y8X+r9ppZiNYhUPZGwiS7gh9+hO9e59oQXQue53k1 l8KOSChSiP0cA== Message-ID: <67eef030-7965-4ea6-a390-568c18ae9451@kernel.org> Date: Tue, 21 May 2024 11:04:51 +0200 Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] ASoC: dt-bindings: ssm2305: convert to dt schema To: Xiaxi Shen , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org, javier.carrasco.cruz@gmail.com, skhan@linuxfoundation.org Cc: lgirdwood@gmail.com, broonie@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org References: <20240511214716.242807-1-shenxiaxi26@gmail.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: <20240511214716.242807-1-shenxiaxi26@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 11/05/2024 23:47, Xiaxi Shen wrote: > Convert adi,ssm2305 binding to DT schema > > It passed dt_binding_check and dtbs_check. Let me know > if you think it should include something else That's not really related to the commit. > > Signed-off-by: Xiaxi Shen > --- > .../devicetree/bindings/sound/adi,ssm2305.txt | 14 -------- > .../bindings/sound/adi,ssm2305.yaml | 35 +++++++++++++++++++ Same comment as usual... there are no DTS users. Are we done with arm64 defconfig and arm multi_v7 undocumented compatibles? I doubt, 2 months ago there were hundreds of them. Why touching something without users? I was speaking about this *multiple times*. Can you update your GSoC or mentorship guidelines to include this information? > 2 files changed, 35 insertions(+), 14 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/sound/adi,ssm2305.txt > create mode 100644 Documentation/devicetree/bindings/sound/adi,ssm2305.yaml > ... > +maintainers: > + - Liam Girdwood > + - Mark Brown > + - Rob Herring > + - Krzysztof Kozlowski > + - Conor Dooley Not really, this should be someone responsible for the device. No maintainers or recent, main contributors? > + > +properties: > + compatible: > + const: adi,ssm2305 > + > + shutdown-gpios: > + maxItems: 1 > + description: The gpio connected to the shutdown pin. The gpio signal is ACTIVE_LOW. > + > +required: > + - compatible > + - shutdown-gpios> + > +additionalProperties: false > + > +examples: > + - | > + analog-amplifier { > + compatible = "adi,ssm2305"; > + shutdown-gpios = <&gpio3 20 0>; Use proper define for the flag. > + }; Best regards, Krzysztof