From: Markus Elfring <Markus.Elfring@web.de>
To: Zhu Jun <zhujun2@cmss.chinamobile.com>,
linux-sound@vger.kernel.org, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Heiko Stübner" <heiko@sntech.de>,
"Kuninori Morimoto" <kuninori.morimoto.gx@renesas.com>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Mark Brown" <broonie@kernel.org>,
"Nathan Chancellor" <nathan@kernel.org>,
"Uwe Kleine-König" <u.kleine-koenig@baylibre.com>,
"Weidong Wang" <wangweidong.a@awinic.com>
Subject: Re: [PATCH] ASoC: codecs: aw88399: Correct error handling in aw_dev_get_dsp_status function
Date: Tue, 8 Oct 2024 08:32:32 +0200 [thread overview]
Message-ID: <6849d647-0240-4d3b-8f35-e4e65397e389@web.de> (raw)
In-Reply-To: <20241008025923.10606-1-zhujun2@cmss.chinamobile.com>
* Please check the subsystem specification once more.
* How do you think about to replace the word “function” (in the summary phrase)
by parentheses?
> Added proper error handling for register value check that
Add?
> return -EPERM when register value does not meet expected condition
* It is usually preferred to end a sentence with a dot, isn't it?
* Would you like to add any tags (like “Fixes” and “Cc”) accordingly?
Regards,
Markus
next prev parent reply other threads:[~2024-10-08 6:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-08 2:59 [PATCH] sound:aw88399:Correct error handling in aw_dev_get_dsp_status function Zhu Jun
2024-10-08 6:32 ` Markus Elfring [this message]
2024-10-08 9:49 ` [PATCH] ASoC: codecs: aw88399: Correct " Mark Brown
2024-10-08 9:48 ` [PATCH] sound:aw88399:Correct " Mark Brown
2024-10-10 11:14 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6849d647-0240-4d3b-8f35-e4e65397e389@web.de \
--to=markus.elfring@web.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=broonie@kernel.org \
--cc=heiko@sntech.de \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=nathan@kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=u.kleine-koenig@baylibre.com \
--cc=wangweidong.a@awinic.com \
--cc=zhujun2@cmss.chinamobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox