From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5DB4B343D84 for ; Fri, 17 Oct 2025 11:28:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760700482; cv=none; b=NbbYR9cF8tO74tZGe7Oy+aYUUxeaDZBTAdZ5pzl2hHUrEus9AQaHRc7vTdRM3W8kQJWrYwrDEIbW4Zq12DuIgey+3lp3yHPE6D7F4EYzJtCEsa6Ow1XtOkK79QJSc9wtYaecJdhuZ6j2QBl1pGxp6pUk8+EyqZQM9ynUD1ZtquA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760700482; c=relaxed/simple; bh=kgBl8a0kCckWI8aKDofLzcUZxyOfjZE0zQsu0tHmUBo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=D+NuQcEjhEGr58eaKy+venn1yC5r5hmXb6AbAR2v3vBGlAi+3TwNo0+8eiARlyubYI3KWkuev9J95tmNOdNdzFXWaPiYeGVzImRyHT63eBr47dfiPEhaAZU26KBXOrZKT7EnWB1tGjRg501ZN15nlgz6C3wjq5wVFEoVlNct1t8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=JAGY2tnw; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="JAGY2tnw" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 59H8GR3D008872 for ; Fri, 17 Oct 2025 11:28:00 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= MO5yMJK0yFYcV1Jdm5K+ratgjKv8CSI3SXjH6E3HP98=; b=JAGY2tnwgKBfOduF HG6xOc9AC1c51yQJissWfLx5Rc9B0foY9NJKx5JLuP0pB+0/uK+nnsqI50ndwu1L 0Y1i/exNRdhcEtNPkbIdrel0i/dHgbukJd4IyQOF88MK1xCy3bufF4IUsC7i46Nv BJBzah5MXT0NcaKdLR9NEjzGyRD14yAMEnFEdTLSXcVVmkj2VKPGLFrJzl8nU8Dk AvYTWKiYQgxjuSV3KgQebgFTLYm6MZ8c7oKocQTj4VmG19sD/xx5RLdmQ/H8yuu9 Sa2NA3p4/9w8T2DCNuV++DFmpSAoGfOjTr2KA1CzcfORyz1jqynX3PLeeI4rp9du sM1ezA== Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 49rw1ar7tt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 17 Oct 2025 11:28:00 +0000 (GMT) Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-81d800259e3so29577926d6.3 for ; Fri, 17 Oct 2025 04:28:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760700479; x=1761305279; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=MO5yMJK0yFYcV1Jdm5K+ratgjKv8CSI3SXjH6E3HP98=; b=DL3Vr4cswyp4iNH/M/HVA+FMFEjepj6brX2WYiXd0PhYyg6Hg1p5196PZOFCNZwOtW AbN8p0Ko3Y1x7PInBLJ1sqIJeLBKu4Ian84gK3qZdIFwNA4amezXyIcZByjEot7UapML 49XYBUQL4di7n9JUfeyJNw5XC8MIOlUeUJbxtzs9X/CH6mwLU9LX29WxtuIMfuOYn6pb KB26uzed6ZirfyLio8ilSOxKxq3XErk7p0lXPHTJWoTrV2R8C9FriB61J6QB+ZUWOLau glfjVjabB2Db8DJB+jIkm1sOGuDZf0BfZKCs6eyO3DURFdCPuBBdG2XIzp76XPS3u8/k sNeg== X-Forwarded-Encrypted: i=1; AJvYcCUOZbqYUCvVMMkBvlqh06GzBYHHpIi76ByGkF64MKm1cZzDRE/irQ7R8nZjokBbwmStkpOrOx31uSbFrg==@vger.kernel.org X-Gm-Message-State: AOJu0YzD6mjO7WtTMhyi24wOYE0PC87zxzSUzKidzhb3DQ5AyL2ECgtz zqKVA+wJ7G6kdtFFg1DnIfoEQLU0v8E7fBmurjMZGiezywDmKBkR642RjIp2lm0WdZAjwajoo8l OK5RSpcJy5dEu3FWz2aoGMS2/6OnCA4AocWcPVQ651ecwpn/v1xfplkbQAT31vT2GSA== X-Gm-Gg: ASbGncvn2sA+a1h4fpun9b38ufNx2qkr5tQTmxqqFPzJJ17n9tWpt1iykP4G4jIfXAt AYOEBmUUNxPcZwSd7KIFa6ZTe00H9zBoLdko0VxlsMtLQwr5PrxQXkGhuP9ypneJr6oaVgCyoda uGktM3yV4BjxYPBXmGdM6mhcsWgaEymZC39zV+tU5N7OiNx2rC5xMvAbgBY+aQEdZIIs/IZ8LxX CP1x1lAgpj7ia2pxrZbBMiEkG9QGbZDlV5PQQ58vGEkAfhMhL2usf7PAtc9WOd0lRbdrIUUXCcS mDvkhgjOFd9ZYn0rHJHbei+UUn4ezrH6ggh95OZIueuzt558KG2T18Y8S80oCGlhI64Q/6LzcGP 9TuFYG90ZcOYxBSFAl+vhiBxMeA== X-Received: by 2002:ac8:7f41:0:b0:4d9:5ce:374a with SMTP id d75a77b69052e-4e89d35c6b2mr42058241cf.53.1760700478987; Fri, 17 Oct 2025 04:27:58 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFDIffwZXUxQwetzttdf8IHIykBBw7PC3C1BL7U7ffezRNN/D8uA16UnjK/MXp5jsm3ACZpXg== X-Received: by 2002:ac8:7f41:0:b0:4d9:5ce:374a with SMTP id d75a77b69052e-4e89d35c6b2mr42057911cf.53.1760700478410; Fri, 17 Oct 2025 04:27:58 -0700 (PDT) Received: from [192.168.68.121] ([5.133.47.210]) by smtp.googlemail.com with ESMTPSA id ffacd0b85a97d-426ff65596csm8996956f8f.24.2025.10.17.04.27.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Oct 2025 04:27:57 -0700 (PDT) Message-ID: <695ff482-ad53-45fc-9ab0-ad69d8bc89d5@oss.qualcomm.com> Date: Fri, 17 Oct 2025 12:27:55 +0100 Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] dt-bindings: sound: qcom,sm8250: add QRB2210 and RB1 soundcards To: Alexey Klimov , Dmitry Baryshkov , Krzysztof Kozlowski Cc: Srinivas Kandagatla , Liam Girdwood , Mark Brown , Rob Herring , Conor Dooley , Jaroslav Kysela , Takashi Iwai , linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20251007-qrb2210-qcm2290-sndcard-v1-0-8222141bca79@linaro.org> <20251007-qrb2210-qcm2290-sndcard-v1-1-8222141bca79@linaro.org> Content-Language: en-US From: Srinivas Kandagatla In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=K88v3iWI c=1 sm=1 tr=0 ts=68f22840 cx=c_pps a=UgVkIMxJMSkC9lv97toC5g==:117 a=ZsC4DHZuhs/kKio7QBcDoQ==:17 a=IkcTkHD0fZMA:10 a=x6icFKpwvdMA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=VwQbUJbxAAAA:8 a=KKAkSRfTAAAA:8 a=lrA9asLDxIyQxDedMN0A:9 a=QEXdDO2ut3YA:10 a=1HOtulTD9v-eNWfpl4qZ:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-GUID: A9MHW8JA6pnnuQ6iPhapjBK8ug2NzJOe X-Proofpoint-ORIG-GUID: A9MHW8JA6pnnuQ6iPhapjBK8ug2NzJOe X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMDEzMDAzNSBTYWx0ZWRfX30BdgkxZMKrZ LEJ4HgaLwnDyFqlxY08abjTjQT9nkUt9TDaIvb7kM8yod22v0us1gFuUkLEYhtXTfOMfc+Ff5xx 7WCiTdlLOuDfYPEDTml2yB0loqWEspoyP3U769Ma4VJWZvdRvBvnoWQ2KOXTNB/Uhftxp3gZ+V6 bZsOEemYr9B+/yeINCJJ4oB3P/9O2Fd1GzxydoaIMq44/QTbWuNAKAV0cuaPrmgxafGby1wUGu4 wn5fz/VQbsG4lJ5a+bdQbNGypls8b7/PelvFer9lFm8AGaSh6Uwq9jThR9r/TmfopWNytwyG0P7 2I40KfXuQuAWthT/+zBTbEzATVuZTJD7zAMV0oSjzDjSNp5XAUSZpvz8Bn58N6XhAwjvDRot9rR 1X62AUG3ktqZdUUSBMDkNStnPJl/Kw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-10-17_04,2025-10-13_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 spamscore=0 impostorscore=0 priorityscore=1501 phishscore=0 adultscore=0 clxscore=1015 bulkscore=0 suspectscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2510020000 definitions=main-2510130035 On 10/17/25 8:35 AM, Alexey Klimov wrote: > On Thu Oct 16, 2025 at 8:46 PM BST, Dmitry Baryshkov wrote: >> On Thu, 16 Oct 2025 at 18:08, Srinivas Kandagatla >> wrote: >>> >>> >>> >>> On 10/7/25 2:26 AM, Alexey Klimov wrote: >>>> Add soundcard compatible for QRB2210 (QCM2290) platforms. >>>> While at this, also add QRB2210 RB1 entry which is set to be >>>> compatible with QRB2210 soundcard. >>>> >>>> Cc: Srinivas Kandagatla >>>> Signed-off-by: Alexey Klimov >>>> --- >>>> Documentation/devicetree/bindings/sound/qcom,sm8250.yaml | 5 +++++ >>>> 1 file changed, 5 insertions(+) >>>> >>>> diff --git a/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml b/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml >>>> index 8ac91625dce5ccba5c5f31748c36296b12fac1a6..c29e59d0e8043fe2617b969be216525b493458c4 100644 >>>> --- a/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml >>>> +++ b/Documentation/devicetree/bindings/sound/qcom,sm8250.yaml >>>> @@ -21,6 +21,10 @@ properties: >>>> - lenovo,yoga-c630-sndcard >>>> - qcom,db845c-sndcard >>>> - const: qcom,sdm845-sndcard >>>> + - items: >>>> + - enum: >>>> + - qcom,qrb2210-rb1-sndcard >>> I don't think you need rb1 specific compatible here, unless there this >>> is totally different to what the base compatible can provide. >> >> Why do we need to deviate from other platforms which declare >> board-specific compat too? > > There seems to be now a few incompatible suggestions for rb1 sndcard: > - make it compatible/fallback to qcom,sm8250-sndcard (1); > - make it compatible/fallback to qcom,qrb4210-rb2-sndcard (2); > - add separate compatible/enum for rb1 sndcard as qcom,qrb2210-rb1-sndcard (3); > - add base compatible as qcom,qrb2210-sndcard and fallback > rb1 sndcard compatible to it. > > The latter one is ruled out because base compatible should be used and > it is not going to. > > As far as I can see the last addition went simply with (3). > Which one finally you all want? Am fine with either "qcom,sm8250-sndcard" or "qcom,qrb4210-rb1-sndcard" as long as we reflect that correct driver name in machine driver. traditionally we have SoC level compatible which works fine for 99% of the boards for that SoC, expectation was that if there is any deviation or board specific changes required, this can be accommodate using model information. am fine with board specific compatible too, however am not okay with both "qcom,sm8250-sndcard" and "qcom,qrb4210-rb1-sndcard" or falling back to another board compatible for various reason one being ucm. So 1 and 2 re *NOK* I hope this provides some clarity here. thanks, Srini> > Best regards, > Alexey >