From: Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>
To: Charles Keepax <ckeepax@opensource.cirrus.com>, vkoul@kernel.org
Cc: yung-chuan.liao@linux.intel.com, linux-sound@vger.kernel.org,
linux-kernel@vger.kernel.org, patches@opensource.cirrus.com
Subject: Re: [PATCH v3 0/2] Update handling of min and max channel in DisCo
Date: Thu, 12 Nov 2026 08:56:50 +0100 [thread overview]
Message-ID: <69e3aa67-aa99-4d27-abd7-8faf2d58a3a9@linux.dev> (raw)
In-Reply-To: <20261111162445.1371853-1-ckeepax@opensource.cirrus.com>
On 11/11/26 17:24, Charles Keepax wrote:
> The DisCo properties "mipi-sdw-min-channel-number" and
> "mipi-sdw-max-channel-number" are both channel indexes rather than
> counts. Update the kernel code to more accurately reflect this.
>
> There are a few Qualcomm drivers that likely specify these incorrect,
> min_ch=1, max_ch=X, rather than min_ch=0, max_ch=X-1, however these
> should work fine as the number of supported channels is equivalent.
> If people feel strongly I can send another series to fix those up.
>
> Changes since v2:
> - Moved the parsing of min/max channels to only be processed if
> num_channels is missing
>
> Changes since v1:
> - Update wording on min_ch/max_ch comments
>
> Charles Keepax (2):
> soundwire: Improve channel min/max comments
> soundwire: Assume default maximum valid channel if not specified
>
> drivers/soundwire/mipi_disco.c | 14 ++++++++------
> include/linux/soundwire/sdw.h | 4 ++--
> 2 files changed, 10 insertions(+), 8 deletions(-)
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>
prev parent reply other threads:[~2026-11-12 8:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-11 16:24 [PATCH v3 0/2] Update handling of min and max channel in DisCo Charles Keepax
2026-11-11 16:24 ` [PATCH v3 1/2] soundwire: Improve channel min/max comments Charles Keepax
2026-11-11 16:24 ` [PATCH v3 2/2] soundwire: Assume default maximum valid channel if not specified Charles Keepax
2026-11-12 7:56 ` Pierre-Louis Bossart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=69e3aa67-aa99-4d27-abd7-8faf2d58a3a9@linux.dev \
--to=pierre-louis.bossart@linux.dev \
--cc=ckeepax@opensource.cirrus.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=vkoul@kernel.org \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox