Re: [PATCH v2 11/11] ASoC: dt-bindings: mediatek,mt8196-mt6681: add mt8196-mt6681 document

[Krzysztof Kozlowski <krzk@kernel.org>]

On 07/04/2025 14:06, Darren.Ye wrote:
> +
> +allOf:
> +  - $ref: sound-card-common.yaml#
> +
> +properties:
> +  compatible:
> +    oneOf:

Drop

> +      - enum:
> +          - mediatek,mt8196-mt6681-sound
> +          - mediatek,mt8196-nau8825-sound
> +          - mediatek,mt8196-rt5682s-sound
> +          - mediatek,mt8196-rt5650-sound
> +
> +  audio-routing:
> +    description:
> +      Valid names could be the input or output widgets of audio components,
> +      power supplies, MicBias of codec and the software switch.
> +
> +  mediatek,platform:
> +    $ref: /schemas/types.yaml#/definitions/phandle
> +    description: The phandle of MT8188 ASoC platform.
> +
> +  mediatek,adsp:
> +    $ref: /schemas/types.yaml#/definitions/phandle
> +    description:
> +      The phandle of the MT8188 ADSP platform, which is the optional Audio DSP
> +      hardware that provides additional audio functionalities if present.
> +      The AFE will link to ADSP when the phandle is provided.
> +
> +patternProperties:
> +  "^dai-link-[0-9]+$":
> +    type: object
> +    description:
> +      Container for dai-link level properties and CODEC sub-nodes.
> +

Everything looks here exactly the same as mt8188-mt6359, except accdet.
Are you sure, really, really sure these are different and you do not
have accdet?

> +    properties:
> +      link-name:
> +        description:
> +          This property corresponds to the name of the BE dai-link to which
> +          we are going to update parameters in this node.
> +        items:
> +          enum:
> +            - TDM_DPTX_BE
> +            - I2SOUT6_BE
> +            - I2SIN6_BE
> +            - I2SOUT4_BE
> +            - I2SOUT3_BE
> +
> +      codec:
> +        description: Holds subnode which indicates codec dai.
> +        type: object
> +        additionalProperties: false
> +        properties:
> +          sound-dai:
> +            minItems: 1
> +            maxItems: 2
> +        required:
> +          - sound-dai
> +
> +      dai-format:
> +        description: audio format.
> +        items:
> +          enum:
> +            - i2s
> +            - right_j
> +            - left_j
> +            - dsp_a
> +            - dsp_b
> +
> +      mediatek,clk-provider:
> +        $ref: /schemas/types.yaml#/definitions/string
> +        description: Indicates dai-link clock master.
> +        items:
> +          enum:
> +            - cpu
> +            - codec
> +
> +    additionalProperties: false
> +
> +    required:
> +      - link-name
> +
> +unevaluatedProperties: false
> +
> +required:
> +  - compatible
> +  - mediatek,platform
> +
> +examples:
> +  - |
> +    sound {
> +        compatible = "mediatek,mt8196-mt6681-sound";
> +        model = "mt8196-mt6681";
> +        mediatek,platform = <&afe>;

Make the example complete.



Best regards,
Krzysztof