From: Mark Brown <broonie@kernel.org>
To: Richard Fitzgerald <rf@opensource.cirrus.com>
Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
patches@opensource.cirrus.com, kunit-dev@googlegroups.com,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH] ASoC: cs-amp-lib-test: Don't select SND_SOC_CS_AMP_LIB
Date: Wed, 9 Apr 2025 15:37:45 +0100 [thread overview]
Message-ID: <6e94dd2e-e242-4bff-be85-d3029fb08693@sirena.org.uk> (raw)
In-Reply-To: <5feaca10-f3bc-49bb-8e5b-9d9efa918e16@opensource.cirrus.com>
[-- Attachment #1: Type: text/plain, Size: 667 bytes --]
On Wed, Apr 09, 2025 at 03:34:27PM +0100, Richard Fitzgerald wrote:
> On 09/04/2025 3:24 pm, Mark Brown wrote:
> > This by itself results in the Cirrus tests being removed from a kunit
> > --alltests run which is a regression in coverage. I'd expect to see
> > some corresponding updates in the KUnit all_tests.config to keep them
> > enabled.
> That's the defined behaviour of KUNIT_ALL_TESTS. It shouldn't have been
> running as part of an alltests if nothing had selected it. That seems to
> make people angry. Probably the same people who would complain if there
> was a bug in the code that they didn't want to test.
Hence the updates to all_tests.config...
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2025-04-09 14:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-09 10:45 [PATCH] ASoC: cs-amp-lib-test: Don't select SND_SOC_CS_AMP_LIB Richard Fitzgerald
2025-04-09 14:24 ` Mark Brown
2025-04-09 14:34 ` Richard Fitzgerald
2025-04-09 14:37 ` Mark Brown [this message]
2025-04-14 13:56 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6e94dd2e-e242-4bff-be85-d3029fb08693@sirena.org.uk \
--to=broonie@kernel.org \
--cc=kunit-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=rf@opensource.cirrus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox