Re: [PATCH v6 0/7] Add DAPM/ASoC helpers to create SDCA drivers

[Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>]

On 5/16/25 15:10, Charles Keepax wrote:
> Add helper functions to add DAPM widgets, routes, ALSA controls,
> and DAI drivers, these will be used to create SDCA function device
> drivers.
> 
> This series should provide most of the core functionality needed to
> get a device registered and have a working DAPM graph within the
> device. There are some features that still need additional work, these
> are marked with FIXMEs in the code. The two main things are SDCA
> Clock Muxes (not used in our devices and needs some ASoC core work),
> and better support for more complex SDCA volume control definitions
> (our parts have fairly simple volumes, and SDCA has a large amount of
> flexibility in how the volume control is specified).
> 
> The next steps in the process are to add helpers for the DAI ops
> themselves, some IRQ handling, and firmware download. And finally we
> should be able to actually add the SDCA class driver itself.
> 
> Thanks,
> Charles
> 
> Changes since v5:
>  - Add small typo fixup patch.
>  - Move and add some comments.
>  - Switch from fixed poll time to fixed number of polls waiting for PDEs.
>  - Generate read only ALSA controls where appropriate.
>  - Export ALSA controls for SDCA controls with fixed values.
>  - Clamp control values to range supported by ALSA.
>  - Force export of a control for DETECTED_MODE.

Looks good to me, thanks Charles for bearing with my delayed feedback. For the series:

Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>
 
> Charles Keepax (7):
>   ASoC: SDCA: Fix minor typo
>   ASoC: SDCA: Remove regmap module macros
>   ASoC: SDCA: Move allocation of PDE delays array
>   ASoC: dapm: Add component level pin switches
>   ASoC: SDCA: Create DAPM widgets and routes from DisCo
>   ASoC: SDCA: Create ALSA controls from DisCo
>   ASoC: SDCA: Create DAI drivers from DisCo
> 
>  include/sound/sdca_asoc.h       |   42 +
>  include/sound/sdca_function.h   |   71 +-
>  include/sound/soc-dapm.h        |    4 +
>  sound/soc/sdca/Makefile         |    2 +-
>  sound/soc/sdca/sdca_asoc.c      | 1311 +++++++++++++++++++++++++++++++
>  sound/soc/sdca/sdca_functions.c |   10 +-
>  sound/soc/sdca/sdca_regmap.c    |    3 -
>  sound/soc/soc-dapm.c            |   84 +-
>  8 files changed, 1502 insertions(+), 25 deletions(-)
>  create mode 100644 include/sound/sdca_asoc.h
>  create mode 100644 sound/soc/sdca/sdca_asoc.c
>