From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D91EAD29B; Sun, 21 Apr 2024 18:25:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713723911; cv=none; b=DytJxTt73j9HrKBye5nX5RZ1fx51sP/nN5EdqaugrUPFKF65pIk76iT2Y5jvotir0QUXGnahddQVb6Ypmt3V381W5AElDT+AVDqvyGDDIEKj5f0Iok81ut5Yk4j+cMfPtjiuWtUaR5UOuxfU/3wqeoAg4BrzaxgBOe1QyVD1csc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713723911; c=relaxed/simple; bh=CU4y/tEi/dfSogv5NvsyF9x+2KxTRNPBD+gEADHy+yw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=C2FWp2hn/B2foodPAC/pL5N6hoTsmEn2j1+D7qhD7H9+w2/p2bNW/gDuHzGRF8iygGHeA4yMAfpK12kjhxnZMSGtKHOJO+X0SW+6I/3FufickfaS/49BLEf/R1HEWr7iJUvgS7RGmUwuY0vHUrxjKJDtHxLOUJVgb/2O0pDJK/Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=g0lijnD6; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="g0lijnD6" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B36EEC113CE; Sun, 21 Apr 2024 18:25:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1713723910; bh=CU4y/tEi/dfSogv5NvsyF9x+2KxTRNPBD+gEADHy+yw=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=g0lijnD67li+xsHW8VvqM7/Krq3AGarKKDtlKvO9UDHsXDmZZ+dbCsexftXqXfPq5 O1FkaW7EfZjqrxGpzYn/cTyEdUFmuu25nykGP8YohJYOLjQidSJ87Jo72AW9A3vFpZ zqWdNgXv+af1haffW873LKEKjypciMzVF/AeIHF4eHDllkO5yu6W/fr3r1PJkl3WiX cvOgQNOhzk6PK1u2JlFedZKz+z1LpguNSPo6k/CUNy6d21sh74OJ8KEZXuEdUB2iK/ gKASysWwdB0503ltnWlq6HRG8dhFBtSDuQLvfYhhw0IWOqb/T20zacN4orjOj+BRYZ AOVzn7IthZLyg== Message-ID: <7ab1861d-ea57-43f2-81f5-ed06076702f3@kernel.org> Date: Sun, 21 Apr 2024 20:25:03 +0200 Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] ASoC: dt-bindings: tegra20-ac97: convert to dt schema To: Mohammad Shehar Yaar Tausif , Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Thierry Reding , Jonathan Hunter Cc: Thierry Reding , linux-sound@vger.kernel.org, devicetree@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org References: <20240421110929.139191-1-sheharyaar48@gmail.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: <20240421110929.139191-1-sheharyaar48@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 21/04/2024 13:09, Mohammad Shehar Yaar Tausif wrote: > Convert NVIDIA Tegra20 AC97 binding to DT schema. > > Signed-off-by: Mohammad Shehar Yaar Tausif Thank you for your patch. There is something to discuss/improve. > -}; > diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra20-ac97.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra20-ac97.yaml > new file mode 100644 > index 000000000000..e7ffa93eec30 > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/nvidia,tegra20-ac97.yaml > @@ -0,0 +1,80 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sound/nvidia,tegra20-ac97.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# All my other comments apply. Please confirm that you tested DTS. > + > +title: NVIDIA Tegra20 AC97 controller > + > +maintainers: > + - Thierry Reding > + - Jon Hunter > + > +properties: > + compatible: > + const: nvidia,tegra20-ac97 > + > + reg: > + maxItems: 1 > + > + resets: > + maxItems: 1 > + > + reset-names: > + const: ac97 > + > + interrupts: > + maxItems: 1 > + > + clocks: > + minItems: 1 Nope, this must be maxItems instead. > + > + dmas: > + minItems: 2 No, maxItems instead. > + > + dma-names: > + items: > + - const: rx > + - const: tx > + > + nvidia,codec-reset-gpio: -gpios instead and mention this in commit msg. > + description: | Do not need '|' unless you need to preserve formatting. > + The Tegra GPIO controller's phandle and the number > + of the GPIO used to reset the external AC97 codec > + maxItems: 1 > + > + nvidia,codec-sync-gpio: > + description: | Ditto > + The Tegra GPIO controller's phandle and the number > + of the GPIO corresponding with the AC97 DAP _FS line > + maxItems: 1 > + > +required: > + - compatible > + - reg > + - resets > + - reset-names > + - interrupts > + - clocks > + - dmas > + - dma-names > + - nvidia,codec-reset-gpio > + - nvidia,codec-sync-gpio > + > +additionalProperties: false > + > +examples: > + - | > + ac97@70002000 { > + compatible = "nvidia,tegra20-ac97"; > + reg = <0x70002000 0x200>; > + resets = <&tegra_car 3>; All previous comments apply... > + reset-names = "ac97"; > + interrupts = <0 81 0x04>; Use proper defines. > + clocks = <&tegra_car 3>; > + dmas = <&apbdma 12>, <&apbdma 12>; > + dma-names = "rx", "tx"; > + nvidia,codec-reset-gpio = <&gpio 170 0>; Include gpio header and use proper defines. Best regards, Krzysztof