Re: [PATCH] ASoC: soc-pcm: tidyup function name to snd_soc_dpcm_be_can_xxx()

["Amadeusz Sławiński" <amadeuszx.slawinski@linux.intel.com>]

On 3/6/2025 2:59 AM, Kuninori Morimoto wrote:
> We have similar but different function names
> 
> 	snd_soc_dpcm_fe_can_xxx()
> 	snd_soc_dpcm_be_can_xxx()
> 	snd_soc_dpcm_can_be_xxx()
> 	             ~~~~~~
> Let's unified these to can_xx
> 
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---
>   sound/soc/soc-pcm.c | 18 +++++++++---------
>   1 file changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/sound/soc/soc-pcm.c b/sound/soc/soc-pcm.c
> index 8d88971bdea3..73b05b8f5a07 100644
> --- a/sound/soc/soc-pcm.c
> +++ b/sound/soc/soc-pcm.c
> @@ -36,7 +36,7 @@ static inline int _soc_pcm_ret(struct snd_soc_pcm_runtime *rtd,
>   
>   /* is the current PCM operation for this FE ? */
>   #if 0
> -static int snd_soc_dpcm_fe_can_update(struct snd_soc_pcm_runtime *fe, int stream)
> +static int snd_soc_dpcm_can_fe_update(struct snd_soc_pcm_runtime *fe, int stream)
>   {
>   	if (fe->dpcm[stream].runtime_update == SND_SOC_DPCM_UPDATE_FE)
>   		return 1;
> @@ -1632,7 +1632,7 @@ void dpcm_be_dai_stop(struct snd_soc_pcm_runtime *fe, int stream,
>   			return;
>   
>   		/* is this op for this BE ? */
> -		if (!snd_soc_dpcm_be_can_update(fe, be, stream))
> +		if (!snd_soc_dpcm_can_be_update(fe, be, stream))

Not sure if some part of patch is missing, but shouldn't definition of 
snd_soc_dpcm_be_can_update() be converted somewhere? I see only calls 
and _fe variant.