Linux Sound subsystem development
 help / color / mirror / Atom feed
From: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
To: Alexey Klimov <alexey.klimov@linaro.org>, broonie@kernel.org
Cc: perex@perex.cz, tiwai@suse.com, srini@kernel.org,
	linux-sound@vger.kernel.org, m.facchin@arduino.cc,
	linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 5/9] ASoC: qcom: q6asm: handle the responses after closing
Date: Mon, 20 Oct 2025 15:37:57 +0100	[thread overview]
Message-ID: <7c0dad34-cb4c-4912-9406-2e559b91142a@oss.qualcomm.com> (raw)
In-Reply-To: <DDN83LOTCUIP.5O05FBN02AZB@linaro.org>

On 10/20/25 3:35 PM, Alexey Klimov wrote:
> On Wed Oct 15, 2025 at 2:17 PM BST, Srinivas Kandagatla wrote:
>> For record path, multiple read requests are queued to dsp in advance.
>> However when data stream is closed, the pending read requests are rejected
>> by the dsp and a response is sent to the driver, this case is not handled
>> in the driver resulting in errors like below
>>
>> q6asm-dai ab00000.remoteproc:glink-edge:apr:service@7:dais: command[0x10dac] not expecting rsp
>> q6asm-dai ab00000.remoteproc:glink-edge:apr:service@7:dais: command[0x10dac] not expecting rsp
>> q6asm-dai ab00000.remoteproc:glink-edge:apr:service@7:dais: command[0x10dac] not expecting rsp
>>
>> This is same for both write and eos.
>>
>> Fix this by allowing ASM_DATA_CMD_READ_V2, ASM_DATA_CMD_EOS and
>> ASM_DATA_CMD_WRITE_V2 as expected response.
>>
>> Reported-by: Martino Facchin <m.facchin@arduino.cc>
>> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
> 
> I was also reporting this error months ago.
> Thanks for fixing this.
> 
> FWIW there is also DSP timeout error on Audioreach-based platforms.
there should be only one for SPF get state command.

qcom-apm gprsvc:service:2:1: CMD timeout for [1001021] opcode

This is expected as we are checking for DSP readiness and it will
timeout if the dsp is not ready.

--srini



> 
> Thanks,
> Alexey Klimov


  reply	other threads:[~2025-10-20 14:38 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-15 13:17 [PATCH 0/9] ASoC: qcom: q6dsp: fixes and updates Srinivas Kandagatla
2025-10-15 13:17 ` [PATCH 1/9] ASoC: qcom: q6apm-dai: set flags to reflect correct operation of appl_ptr Srinivas Kandagatla
2025-10-15 13:17 ` [PATCH 2/9] ASoC: qcom: q6adm: the the copp device only during last instance Srinivas Kandagatla
2025-10-20 15:12   ` Alexey Klimov
2025-10-15 13:17 ` [PATCH 3/9] ASoC: qcom: qdsp6: q6asm-dai: set 10 ms period and buffer alignment Srinivas Kandagatla
2025-10-15 13:17 ` [PATCH 4/9] ASoC: qcom: q6asm-dai: perform correct state check before closing Srinivas Kandagatla
2025-10-15 13:17 ` [PATCH 5/9] ASoC: qcom: q6asm: handle the responses after closing Srinivas Kandagatla
2025-10-20 14:35   ` Alexey Klimov
2025-10-20 14:37     ` Srinivas Kandagatla [this message]
2025-10-20 14:39       ` Konrad Dybcio
2025-10-20 14:42         ` Srinivas Kandagatla
2025-10-21  9:12           ` Konrad Dybcio
2025-10-21  9:21             ` Srinivas Kandagatla
2025-10-21  9:26               ` Konrad Dybcio
2025-10-15 13:17 ` [PATCH 6/9] ASoC: qcom: q6asm-dai: schedule all available frames to avoid dsp under-runs Srinivas Kandagatla
2025-10-20 16:06   ` Alexey Klimov
2025-10-23  9:25     ` Srinivas Kandagatla
2025-10-15 13:17 ` [PATCH 7/9] ASoC: qcom: q6asm: add q6asm_get_hw_pointer Srinivas Kandagatla
2025-10-20 15:04   ` Alexey Klimov
2025-10-23  9:30     ` Srinivas Kandagatla
2025-10-15 13:17 ` [PATCH 8/9] ASoC: qcom: q6asm-dai: use q6asm_get_hw_pointer Srinivas Kandagatla
2025-10-15 13:17 ` [PATCH 9/9] ASoC: qcom: q6asm: set runtime correctly for each stream Srinivas Kandagatla
2025-10-18  4:55 ` [PATCH 0/9] ASoC: qcom: q6dsp: fixes and updates Alexey Klimov
2025-10-20 16:15 ` Alexey Klimov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7c0dad34-cb4c-4912-9406-2e559b91142a@oss.qualcomm.com \
    --to=srinivas.kandagatla@oss.qualcomm.com \
    --cc=alexey.klimov@linaro.org \
    --cc=broonie@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=m.facchin@arduino.cc \
    --cc=perex@perex.cz \
    --cc=srini@kernel.org \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox