From: Krzysztof Kozlowski <krzk@kernel.org>
To: Oder Chiou <oder_chiou@realtek.com>
Cc: "cezary.rojewski@intel.com" <cezary.rojewski@intel.com>,
"broonie@kernel.org" <broonie@kernel.org>,
"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"robh@kernel.org" <robh@kernel.org>,
"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
"conor+dt@kernel.org" <conor+dt@kernel.org>,
"perex@perex.cz" <perex@perex.cz>,
"linux-sound@vger.kernel.org" <linux-sound@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"Flove(HsinFu)" <flove@realtek.com>,
"Shuming [范書銘]" <shumingf@realtek.com>,
"Jack Yu" <jack.yu@realtek.com>,
"Derek [方德義]" <derek.fang@realtek.com>
Subject: Re: [PATCH v8 2/2] ASoC: dt-bindings: realtek,rt5575: add bindings for ALC5575
Date: Mon, 8 Dec 2025 07:03:16 +0100 [thread overview]
Message-ID: <7dbe62de-2394-407c-9e82-822be5d7bcfb@kernel.org> (raw)
In-Reply-To: <12131cc3-58d9-4755-85d1-84efc125779f@kernel.org>
On 08/12/2025 07:02, Krzysztof Kozlowski wrote:
> On 08/12/2025 06:55, Oder Chiou wrote:
>>>> +properties:
>>>> + compatible:
>>>> + enum:
>>>> + - realtek,rt5575
>>>> + - realtek,rt5575-with-spi
>>>
>>> Drop the second compatible. It's the same device. Whether it supports
>>> SPI it is already known and obvious - you cannot place non-SPI chip on
>>> SPI bus and expect it to work.
>>
>> There are two hardware configurations: with SPI flash and without SPI flash.
>> If the codec is shipped without an SPI flash, the SPI driver can still load
>> the firmware through the SPI interface. The second compatible is intended to
>> distinguish between the versions with and without the SPI flash.
>>
>
> Ah, so this is not about the bus. I don't see that compatible referenced
> in your device ID table, so this is dead code. Drop or justify - by
> writing driver code using it....
>
Wait, I saw it in deice ID table, but there is no driver data so still
pointless.
Best regards,
Krzysztof
prev parent reply other threads:[~2025-12-08 6:03 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-01 10:59 [PATCH v8 0/2] ASoC: rt5575: Add the codec driver for the ALC5575 Oder Chiou
2025-12-01 10:59 ` [PATCH v8 1/2] " Oder Chiou
2025-12-08 6:05 ` Krzysztof Kozlowski
2025-12-08 7:29 ` Oder Chiou
2025-12-08 8:01 ` Krzysztof Kozlowski
2025-12-08 9:16 ` Oder Chiou
2025-12-09 6:07 ` Krzysztof Kozlowski
2025-12-10 5:26 ` Oder Chiou
2025-12-10 9:14 ` Cezary Rojewski
2025-12-08 20:05 ` Cezary Rojewski
2025-12-09 5:35 ` Oder Chiou
2025-12-10 9:22 ` Cezary Rojewski
2025-12-01 10:59 ` [PATCH v8 2/2] ASoC: dt-bindings: realtek,rt5575: add bindings for ALC5575 Oder Chiou
2025-12-05 8:31 ` Krzysztof Kozlowski
2025-12-05 8:31 ` Krzysztof Kozlowski
2025-12-08 5:55 ` Oder Chiou
2025-12-08 5:55 ` Oder Chiou
2025-12-08 6:02 ` Krzysztof Kozlowski
2025-12-08 6:03 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7dbe62de-2394-407c-9e82-822be5d7bcfb@kernel.org \
--to=krzk@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=conor+dt@kernel.org \
--cc=derek.fang@realtek.com \
--cc=devicetree@vger.kernel.org \
--cc=flove@realtek.com \
--cc=jack.yu@realtek.com \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-sound@vger.kernel.org \
--cc=oder_chiou@realtek.com \
--cc=perex@perex.cz \
--cc=robh@kernel.org \
--cc=shumingf@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox