From: Markus Elfring <Markus.Elfring@web.de>
To: Hao Ge <gehao@kylinos.cn>, linux-sound@vger.kernel.org
Cc: LKML <linux-kernel@vger.kernel.org>,
Colin Ian King <colin.i.king@gmail.com>,
Jaroslav Kysela <perex@perex.cz>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Shenghao Ding <shenghao-ding@ti.com>,
Takashi Iwai <tiwai@suse.com>
Subject: Re: [PATCH] ASoc: PCM6240: Fix a null pointer dereference in pcmdevice_i2c_probe
Date: Sat, 15 Jun 2024 08:16:26 +0200 [thread overview]
Message-ID: <82283abf-10b1-4095-a93f-112ba8aca483@web.de> (raw)
In-Reply-To: <20240614024116.22130-1-hao.ge@linux.dev>
…
> +++ b/sound/soc/codecs/pcm6240.c
> @@ -2088,8 +2088,7 @@ static int pcmdevice_i2c_probe(struct i2c_client *i2c)
>
> pcm_dev = devm_kzalloc(&i2c->dev, sizeof(*pcm_dev), GFP_KERNEL);
> if (!pcm_dev) {
> - ret = -ENOMEM;
> - goto out;
> + return -ENOMEM;
> }
…
Would you like to omit curly brackets from a single if branch?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?h=v6.10-rc3#n197
Regards,
Markus
next prev parent reply other threads:[~2024-06-15 6:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-14 2:41 [PATCH] ASoc: PCM6240: Fix a null pointer dereference in pcmdevice_i2c_probe Hao Ge
2024-06-14 20:20 ` Markus Elfring
2024-06-17 11:58 ` Mark Brown
2024-06-15 6:16 ` Markus Elfring [this message]
2024-06-17 2:09 ` [PATCH v2] ASoc: PCM6240: Return directly after a failed devm_kzalloc() in pcmdevice_i2c_probe() Hao Ge
2024-06-23 10:50 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=82283abf-10b1-4095-a93f-112ba8aca483@web.de \
--to=markus.elfring@web.de \
--cc=broonie@kernel.org \
--cc=colin.i.king@gmail.com \
--cc=gehao@kylinos.cn \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=shenghao-ding@ti.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox