From: neil.armstrong@linaro.org
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Banajit Goswami <bgoswami@quicinc.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>
Cc: alsa-devel@alsa-project.org, linux-arm-msm@vger.kernel.org,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 23/23] ASoC: codecs: wcd939x: Drop unused num_ports field
Date: Wed, 12 Jun 2024 18:26:02 +0200 [thread overview]
Message-ID: <828ff7cc-462d-4433-ab68-ce139a31fa24@linaro.org> (raw)
In-Reply-To: <20240612-asoc-wcd9xxx-wide-cleanups-v1-23-0d15885b2a06@linaro.org>
On 12/06/2024 18:15, Krzysztof Kozlowski wrote:
> The driver does not use few 'num_ports' in 'struct wcd939x_sdw_priv'.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> sound/soc/codecs/wcd939x.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/sound/soc/codecs/wcd939x.h b/sound/soc/codecs/wcd939x.h
> index 0aa4d9d542c6..1571c2120cfc 100644
> --- a/sound/soc/codecs/wcd939x.h
> +++ b/sound/soc/codecs/wcd939x.h
> @@ -912,7 +912,6 @@ struct wcd939x_sdw_priv {
> const struct wcd939x_sdw_ch_info *ch_info;
> bool port_enable[WCD939X_MAX_SWR_CH_IDS];
> int active_ports;
> - int num_ports;
> bool is_tx;
> struct wcd939x_priv *wcd939x;
> struct irq_domain *slave_irq;
>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
next prev parent reply other threads:[~2024-06-12 16:26 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-12 16:15 [PATCH 00/23] ASoC: codecs: wcd family: cleanups Krzysztof Kozlowski
2024-06-12 16:15 ` [PATCH 01/23] ASoC: codecs: wcd-mbhc: Constify passed MBHC reg fields Krzysztof Kozlowski
2024-06-12 16:15 ` [PATCH 02/23] ASoC: codecs: wcd9335: Drop unused state container fields Krzysztof Kozlowski
2024-06-12 16:15 ` [PATCH 03/23] ASoC: codecs: wcd9335: Constify static data Krzysztof Kozlowski
2024-06-12 16:15 ` [PATCH 04/23] ASoC: codecs: wcd9335: Handle nicer probe deferral and simplify with dev_err_probe() Krzysztof Kozlowski
2024-06-12 16:15 ` [PATCH 05/23] ASoC: codecs: wcd9335: Drop unneeded error message Krzysztof Kozlowski
2024-06-12 16:15 ` [PATCH 06/23] ASoC: codecs: wcd9335: Drop unused dmic rate handling Krzysztof Kozlowski
2024-06-12 16:15 ` [PATCH 07/23] ASoC: codecs: wcd934x: Drop unused interp path enum Krzysztof Kozlowski
2024-06-12 16:15 ` [PATCH 08/23] ASoC: codecs: wcd934x: Constify static data Krzysztof Kozlowski
2024-06-12 16:15 ` [PATCH 09/23] ASoC: codecs: wcd934x: Drop unused mic bias voltage fields Krzysztof Kozlowski
2024-06-12 16:15 ` [PATCH 10/23] ASoC: codecs: wcd934x: Handle nicer probe deferral and simplify with dev_err_probe() Krzysztof Kozlowski
2024-06-12 16:15 ` [PATCH 11/23] ASoC: codecs: wcd937x: Constify static data Krzysztof Kozlowski
2024-06-12 16:15 ` [PATCH 12/23] ASoC: codecs: wcd937x: Constify wcd937x_sdw_ch_info Krzysztof Kozlowski
2024-06-12 16:15 ` [PATCH 13/23] ASoC: codecs: wcd937x: Drop unused enums, defines and types Krzysztof Kozlowski
2024-06-12 16:15 ` [PATCH 14/23] ASoC: codecs: wcd937x: Drop unused state container fields Krzysztof Kozlowski
2024-06-12 16:15 ` [PATCH 15/23] ASoC: codecs: wcd937x: Drop unused chipid member Krzysztof Kozlowski
2024-06-12 16:15 ` [PATCH 16/23] ASoC: codecs: wcd938x: Constify static data Krzysztof Kozlowski
2024-06-12 16:15 ` [PATCH 17/23] ASoC: codecs: wcd938x: Constify wcd938x_sdw_ch_info Krzysztof Kozlowski
2024-06-12 16:15 ` [PATCH 18/23] ASoC: codecs: wcd938x: Drop unused RX/TX direction enum Krzysztof Kozlowski
2024-06-12 16:15 ` [PATCH 19/23] ASoC: codecs: wcd938x: Drop unused num_ports field Krzysztof Kozlowski
2024-06-12 16:15 ` [PATCH 20/23] ASoC: codecs: wcd939x: Constify static data Krzysztof Kozlowski
2024-06-12 16:25 ` neil.armstrong
2024-06-12 16:15 ` [PATCH 21/23] ASoC: codecs: wcd939x: Constify wcd939x_sdw_ch_info Krzysztof Kozlowski
2024-06-12 16:25 ` neil.armstrong
2024-06-12 16:15 ` [PATCH 22/23] ASoC: codecs: wcd939x: Drop unused RX/TX direction enum Krzysztof Kozlowski
2024-06-12 16:25 ` neil.armstrong
2024-06-12 16:15 ` [PATCH 23/23] ASoC: codecs: wcd939x: Drop unused num_ports field Krzysztof Kozlowski
2024-06-12 16:26 ` neil.armstrong [this message]
2024-06-23 17:21 ` [PATCH 00/23] ASoC: codecs: wcd family: cleanups Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=828ff7cc-462d-4433-ab68-ce139a31fa24@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=bgoswami@quicinc.com \
--cc=broonie@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox