Re: [RFC][PATCH 0/3] ASoC: remove card->pop_time

["Péter Ujfalusi" <peter.ujfalusi@linux.intel.com>]

On 09/04/2026 07:36, Kuninori Morimoto wrote:
> Hi Mark, OMAP member
> 
> I'm now trying to cleanup snd_soc_card, and noticed that card->pop_time is used
> only from OMAP1 board-ams-delta.

The pop_time is an amazingly good tool to debug pop noise and is mostly
used via the debugfs.
You set the pop_time to non 0 and DAPM will 'slow down' and you can
identify the step which produces the pop.

Please, don't remove it!

> 
> card->pop_time user drivers are...
> 
> 	> git grep -w -l pop_time sound/soc include/sound
> 	include/sound/soc.h
> (A)	sound/soc/codecs/cx20442.c
> 	sound/soc/soc-card.c
> 	sound/soc/soc-dapm.c
> (B)	sound/soc/ti/ams-delta.c
> 
> Except ASoC framework, pop_time user is only cx20442 (A) / ams-delta (B).
> And board-ams-delta (Z) is using it.
> 
> (Z)	linux/arch/arm/mach-omap1/board-ams-delta.c
> 
> 	static struct platform_device ams_delta_audio_device = {
> (A)		.name   = "ams-delta-audio",
> 	};
> 
> 	static struct platform_device cx20442_codec_device = {
> (B)		.name   = "cx20442-codec",
> 	};
> 
> 	static struct platform_device *ams_delta_devices[] __initdata = {
> 		...
> (A)		&ams_delta_audio_device,
> 		...
> (B)		&cx20442_codec_device,
> 		...
> 	};
> 
> With off-list talk with Mark, this card->pop_time is is much less of a
> problem. So let's remove it. But it needs Acked-by from OMAP1 member.
> I added [RFC] on Subject.
> 
> Kuninori Morimoto (3):
>   ASoC: ti: amx-delta: don't use card->pop_time
>   ASoC: cx20442: don't use card->pop_time
>   ASoC: soc-card: remvoe card->pop_time
> 
>  include/sound/soc.h        |  2 --
>  sound/soc/codecs/cx20442.c |  3 --
>  sound/soc/soc-core.c       |  3 --
>  sound/soc/soc-dapm.c       | 43 ------------------------
>  sound/soc/ti/ams-delta.c   | 67 +-------------------------------------
>  5 files changed, 1 insertion(+), 117 deletions(-)
> 

-- 
Péter