From: Cezary Rojewski <cezary.rojewski@intel.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: <linux-sound@vger.kernel.org>,
Bard Liao <yung-chuan.liao@linux.intel.com>,
bui duc phuc <phucduc.bui@gmail.com>,
Fabio Estevam <festevam@gmail.com>,
Jaroslav Kysela <perex@perex.cz>,
"Kai Vehmanen" <kai.vehmanen@linux.intel.com>,
Lars-Peter Clausen <lars@metafoo.de>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Nicolin Chen <nicoleotsuka@gmail.com>,
Peter Ujfalusi <peter.ujfalusi@linux.intel.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>,
Shengjiu Wang <shengjiu.wang@gmail.com>,
Takashi Iwai <tiwai@suse.com>, Xiubo Li <Xiubo.Lee@gmail.com>
Subject: Re: [PATCH v3 06/12] ASoC: intel: avs: use snd_soc_register_component()
Date: Mon, 6 Jul 2026 10:55:58 +0200 [thread overview]
Message-ID: <837855bb-307e-4bdd-9148-927442029c3c@intel.com> (raw)
In-Reply-To: <87qzlgc1tu.wl-kuninori.morimoto.gx@renesas.com>
On 7/6/2026 4:02 AM, Kuninori Morimoto wrote:
> It is calling snd_soc_component_initialize() / snd_soc_add_component().
> We can now use snd_soc_register_component() instead.
>
> It is using container_of() to get avs_soc_component from component, but
> will not be able to use it when capsuling has done.
> We can now use snd_soc_component_to_priv() instead.
...
> @@ -1387,25 +1387,33 @@ int avs_register_component(struct device *dev, const char *name,
> struct snd_soc_dai_driver *cpu_dais, int num_cpu_dais)
> {
...
> - ret = snd_soc_component_initialize(&acomp->base, drv, dev);
> + snd_soc_component_set_name(acomp->base, comp_name);
> + snd_soc_component_set_priv(acomp->base, acomp);
> +
> + ret = snd_soc_register_component(acomp->base, drv, cpu_dais, num_cpu_dais);
> if (ret < 0)
> return ret;
>
> - return snd_soc_add_component(&acomp->base, cpu_dais, num_cpu_dais);
> + return 0;
Nitpick: you could just:
return snd_soc_register_component(...);
Note: alone that's not a reason for a resend and v4. I can do that
later when doing my quarterly driver reviews/scans.
> }
>
> static struct snd_soc_dai_driver dmic_cpu_dais[] = {
next prev parent reply other threads:[~2026-07-06 8:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-06 2:01 [PATCH v3 00/12] ASoC: add and use new snd_soc_register_component() Kuninori Morimoto
2026-07-03 1:19 ` [PATCH v3 01/12] ASoC: soc-component: move soc_component_field_shift() Kuninori Morimoto
2026-07-06 2:02 ` [PATCH v3 02/12] ASoC: soc-component: add snd_soc_component_alloc() Kuninori Morimoto
2026-07-06 2:02 ` [PATCH v3 03/12] ASoC: soc-component: add snd_soc_register_component_{c/d}() Kuninori Morimoto
2026-07-06 2:02 ` [PATCH v3 04/12] ASoC: soc-component: add snd_soc_component_{set_}name() Kuninori Morimoto
2026-07-06 2:02 ` [PATCH v3 05/12] ASoC: soc-component: add snd_soc_component_{set/to}_priv() Kuninori Morimoto
2026-07-06 2:02 ` [PATCH v3 06/12] ASoC: intel: avs: use snd_soc_register_component() Kuninori Morimoto
2026-07-06 8:55 ` Cezary Rojewski [this message]
2026-07-06 2:02 ` [PATCH v3 07/12] ASoC: intel: avs: probes: " Kuninori Morimoto
2026-07-06 2:02 ` [PATCH v3 08/12] ASoC: intel: catpt: pcm: " Kuninori Morimoto
2026-07-06 2:02 ` [PATCH v3 09/12] ASoC: soc-generic-dmaengine-pcm: " Kuninori Morimoto
2026-07-06 2:02 ` [PATCH v3 10/12] ASoC: soc-topology-test: " Kuninori Morimoto
2026-07-06 2:02 ` [PATCH v3 11/12] ASoC: soc-core: makes snd_soc_component_initialize() / snd_soc_add_component() local Kuninori Morimoto
2026-07-06 2:03 ` [PATCH v3 12/12] ASoC: soc-core: remove dev from soc_component_initialize() Kuninori Morimoto
2026-07-06 9:01 ` [PATCH v3 00/12] ASoC: add and use new snd_soc_register_component() Cezary Rojewski
2026-07-06 23:11 ` Kuninori Morimoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=837855bb-307e-4bdd-9148-927442029c3c@intel.com \
--to=cezary.rojewski@intel.com \
--cc=Xiubo.Lee@gmail.com \
--cc=broonie@kernel.org \
--cc=festevam@gmail.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=linux-sound@vger.kernel.org \
--cc=nicoleotsuka@gmail.com \
--cc=perex@perex.cz \
--cc=peter.ujfalusi@linux.intel.com \
--cc=phucduc.bui@gmail.com \
--cc=pierre-louis.bossart@linux.dev \
--cc=shengjiu.wang@gmail.com \
--cc=tiwai@suse.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox