Re: [PATCH v12 0/6] Add es9356 focused SoundWire CODEC

[Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>]

On 5/9/26 12:10, Zhang Yi wrote:
> This patch chain adds support for the ES9356 PC focused
> SoundWire CODEC.

for the patchset:

Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>

note that updates will be needed to use new SDCA common helpers for power-up/down and resume.

 
> v12 -> v11:
> 	-Fix a helper function to `hw_params` and `hw_free`
> 	-Move pm_runtime initializations to probe
> 	-Add es9356 to wake_capable_list
> 
> v11 -> v10:
> 	-Add some comment for lock
> 	-Add a helper function to `hw_params` and `hw_free`
> 
> v10 -> v9:
> 	-Add some comment at codec driver
> 	-Fixed the jack_lock issue during suspend
> 
> v9 -> v8:
> 	-Fix some formatting issues in es9356.c
> 	-Removed regmap_write(SDW_SCP_SYSTEMCTRL) from the codec driver
> 
> v8 -> v7:
> 	-When the device status is UNATTACHED,
> 	 set regmap to cache-only and cancel any delay work already in the queue.
> 
> v7 -> v6:
> 	-Provide comments for some parameters
> 	-Rename `jack_detect_work` to `interrupt_handle_work`
> 	-Add a jack_lock when handling disable_irq in suspend
> 	-Adjust the handling procedure when a jack register
> 	 is incorrectly identified
> 	-Replace the custom SOC_SINGLE_Q78_TLV with SDCA_SINGLE_Q78_TLV
> 
> v6 -> v5:
> 	-Handling default values in `button_detect` and `jack_detect`
> 	-Add the member `disable_irq` so that interrupts are
> 	 no longer processed after suspend.
> 	-Move the PDE processing to `hw_params` and `hw_free`
> 	-Separate JACK_OUT and JACK_IN in hw_params
> 	-Simplify reading and writing to SDW_SCP_SDCA_INT1 in the callback
> 	-Adjust the scope of `regcache_sync` in the resume
> 
> v5 -> v4:
> 	-Merge patch1 and patch3
> 	-Add vendor_id in codec_info
> 	-Use q78_get and q78_set to create Kcontrol
> 	-Set mbq_size and use regmap_mbq
> 	-An additional helper function to implement DAPM
> 
> v4 -> v3:
> 	-Updated some KControl names
> 	-add copyright in soc_sdw_es9356
> 
> v3 -> v2:
> 	-Removed unnecessary section in soc_sdw_es9356.c
> 	-Add `pm_runtime_put_noidle` to `es9356.c` to
> 	 reduce device incremented count
> 	-Updated some KControl names
> 	-Fix the error related to jack_report in the codec driver
> 
> v2 -> v1:
> 	-Adjusted mutexes in the ES9356 driver
> 	-Use macros to replace certain values
> 	-Adjusted some ordering issues in Kconfig.
> 
> v1 -> v0:
> 	-Modified snd_soc_dapm_add_routes in soc_sdw_es9356
> 
> Zhang Yi (6):
>   ASoC: sdw_utils: add soc_sdw_es9356
>   ASoC: sdw_utils: add ES9356 in codec_info_list
>   ASoC: es9356-sdca: Add ES9356 SDCA driver
>   ASoC: Intel: soc-acpi: arl: Add es9356 support
>   ASoC: Intel: sof_sdw: add es9356 support
>   soundwire: intel_auxdevice: Add es9356 to wake_capable_list
> 
>  drivers/soundwire/intel_auxdevice.c           |    1 +
>  include/sound/soc_sdw_utils.h                 |   14 +
>  sound/soc/codecs/Kconfig                      |    7 +
>  sound/soc/codecs/Makefile                     |    2 +
>  sound/soc/codecs/es9356.c                     | 1153 +++++++++++++++++
>  sound/soc/codecs/es9356.h                     |  208 +++
>  sound/soc/intel/boards/Kconfig                |    1 +
>  .../intel/common/soc-acpi-intel-arl-match.c   |   52 +
>  sound/soc/sdw_utils/soc_sdw_utils.c           |   50 +
>  9 files changed, 1488 insertions(+)
>  create mode 100644 sound/soc/codecs/es9356.c
>  create mode 100644 sound/soc/codecs/es9356.h
>