From: Takashi Iwai <tiwai@suse.de>
To: Matthew Schwartz <matthew.schwartz@linux.dev>
Cc: Takashi Iwai <tiwai@suse.com>, Jaroslav Kysela <perex@perex.cz>,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] ALSA: hda/realtek: Fix headphone output on ASUS ROG Ally X
Date: Tue, 07 Jul 2026 16:18:33 +0200 [thread overview]
Message-ID: <871pde7uiu.wl-tiwai@suse.de> (raw)
In-Reply-To: <20260707005615.52889-1-matthew.schwartz@linux.dev>
On Tue, 07 Jul 2026 02:56:14 +0200,
Matthew Schwartz wrote:
>
> The ASUS ROG Ally X (RC72LA, PCI SSID 0x1043:0x1eb3) with an ALC294
> codec produces no sound from the headphone jack, and unplugging the
> headphones can leave the speakers muted too.
>
> The device uses ALC287_FIXUP_TAS2781_I2C, which chains into the
> ThinkPad fixup chain. alc285_fixup_thinkpad_x1_gen7() makes the
> headphone (pin 0x21) and speaker (pin 0x17) share DAC 0x03. That is
> correct for a ThinkPad, but here the shared DAC is exposed as a
> "Line Out" control that defaults to zero, so the headphones stay
> silent when plugged in.
>
> Add a dedicated fixup chain for the Ally X that sets up the TAS2781
> amplifier and the headset jack without the ThinkPad DAC sharing, and
> routes the speaker to DAC 0x02 so the headphone and speaker get
> independent DACs.
>
> Also, fixup the wrong product code (it's RC72LA, not RCLA72).
>
> Signed-off-by: Matthew Schwartz <matthew.schwartz@linux.dev>
Applied both patches now. Thanks.
Takashi
prev parent reply other threads:[~2026-07-07 14:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-07 0:56 [PATCH 1/2] ALSA: hda/realtek: Fix headphone output on ASUS ROG Ally X Matthew Schwartz
2026-07-07 0:56 ` [PATCH 2/2] ALSA: hda/realtek: Fix headset mic " Matthew Schwartz
2026-07-07 14:18 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871pde7uiu.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=matthew.schwartz@linux.dev \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox