From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 902CC3DD851 for ; Mon, 29 Jun 2026 10:28:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782728890; cv=none; b=Dg+fwHwV/kVpsJXhuHZA23/sA5MeCmB8lfyJ1nk3jOLrSzxCblFcjqoGpd41BMXazaVdgIeMKNi0FbphQv1PpKwnrJ2hJt1fxHQD95lar5olD0QYxRnB5BWIRm/zspr0JWfBbvRG/EK2OFrh+g4vG4vIVerLrCYwP9IyfLPBu2I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782728890; c=relaxed/simple; bh=DkFklZIhu51hxL2JFPhVwPXHZvJ6F0JPRmbLB53et1w=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=pijzgbEROmFT4mPRZ1K0UA3Eo7aSP+oaKXBQlygkE3h+zyqyr7o3Afss+ma64Rhc99X4J/8j8jymZn+SlAsNOTLT5kfH+CzHmcJpuzYHV2ET6QJetNIIKJ7y5KCLFzWvf8vWRxO2AOarz8f/Te6fpi70dOH6XYvdyif+HMHnwJc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=i2SK+rnR; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=jcnU9vtW; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=i2SK+rnR; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=jcnU9vtW; arc=none smtp.client-ip=195.135.223.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="i2SK+rnR"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="jcnU9vtW"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="i2SK+rnR"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="jcnU9vtW" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id D39237597B; Mon, 29 Jun 2026 10:28:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1782728887; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ep//aNRbcZOPA7FWjjtnh/LztFn+33eGCz9v0HyewMs=; b=i2SK+rnRB9Xn6zWkeROr8eL5w26AlrdmvtbuKlzsBeyDwSeit7N2IH+wWrOUyU4Asv2Wqb /MVZofQL1O2kx2uNBdj5pbH886VgRovfwBGlvIUadrmhw6isRbERTExcIw02UD8zU1wg0+ VFuxK1pDSN/eRPU6+/XAxrd6cUYn/4c= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1782728887; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ep//aNRbcZOPA7FWjjtnh/LztFn+33eGCz9v0HyewMs=; b=jcnU9vtWe2lv+TF2vfmubllMVNdcHQw5T79QCUY1SzUsRr4qu+TENRBTRvMcCYjdmneCX9 BkPhVRS0votuzNAw== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=i2SK+rnR; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=jcnU9vtW DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1782728887; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ep//aNRbcZOPA7FWjjtnh/LztFn+33eGCz9v0HyewMs=; b=i2SK+rnRB9Xn6zWkeROr8eL5w26AlrdmvtbuKlzsBeyDwSeit7N2IH+wWrOUyU4Asv2Wqb /MVZofQL1O2kx2uNBdj5pbH886VgRovfwBGlvIUadrmhw6isRbERTExcIw02UD8zU1wg0+ VFuxK1pDSN/eRPU6+/XAxrd6cUYn/4c= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1782728887; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ep//aNRbcZOPA7FWjjtnh/LztFn+33eGCz9v0HyewMs=; b=jcnU9vtWe2lv+TF2vfmubllMVNdcHQw5T79QCUY1SzUsRr4qu+TENRBTRvMcCYjdmneCX9 BkPhVRS0votuzNAw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id A33E7779A8; Mon, 29 Jun 2026 10:28:07 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id eBM5JrdIQmobHQAAD6G6ig (envelope-from ); Mon, 29 Jun 2026 10:28:07 +0000 Date: Mon, 29 Jun 2026 12:28:07 +0200 Message-ID: <871pdpr688.wl-tiwai@suse.de> From: Takashi Iwai To: Cen Zhang Cc: Jaroslav Kysela , Takashi Iwai , linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, baijiaju1990@gmail.com Subject: Re: [PATCH] ALSA: usb-audio: Release components on probe errors In-Reply-To: <20260618170026.192212-1-zzzccc427@gmail.com> References: <20260618170026.192212-1-zzzccc427@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/30.2 Mule/6.0 Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-Rspamd-Action: no action X-Rspamd-Queue-Id: D39237597B X-Spam-Flag: NO X-Spam-Score: -3.51 X-Spam-Level: X-Spamd-Result: default: False [-3.51 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; MID_CONTAINS_FROM(1.00)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; TO_DN_SOME(0.00)[]; FREEMAIL_TO(0.00)[gmail.com]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; FUZZY_RATELIMITED(0.00)[rspamd.com]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; FREEMAIL_CC(0.00)[perex.cz,suse.com,vger.kernel.org,gmail.com]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_FIVE(0.00)[6]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:106:10:150:64:167:received,2a07:de40:b281:104:10:150:64:97:from]; RCVD_VIA_SMTP_AUTH(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; RCVD_TLS_ALL(0.00)[]; DKIM_TRACE(0.00)[suse.de:+]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:mid,suse.de:dkim,imap1.dmz-prg2.suse.org:rdns,imap1.dmz-prg2.suse.org:helo] X-Rspamd-Server: rspamd1.dmz-prg2.suse.org On Thu, 18 Jun 2026 19:00:26 +0200, Cen Zhang wrote: > > usb_audio_probe() can create USB-audio component resources before the > first interface is recorded in chip->num_interfaces. If a later probe > step fails, the error path drops chip->active and frees the card directly > when no interfaces have been registered. > > Normal disconnect first releases USB-audio components in a fixed order > before the card is freed. The first-interface probe error path skipped > that sequence, so partially initialized PCM, endpoint, MIDI, media, or > mixer resources could be left for the card private_free path without their > disconnect handling having run. > > Move the existing normal-disconnect component release sequence into a > helper and call it from the zero-interface probe error path before > snd_card_free(). Keep the normal disconnect ordering unchanged: PCM > streams, endpoint resources, MIDI 1.0 resources, MIDI 2.0 resources, media > device cleanup, then mixer resources. > > Assisted-by: Codex:gpt-5.5 > Signed-off-by: Cen Zhang Applied to for-next branch now. Thanks. Takashi