Re: [RFC][PATCH 0/3] ASoC: remove card->pop_time

[Takashi Iwai <tiwai@suse.de>]

On Thu, 09 Apr 2026 06:36:48 +0200,
Kuninori Morimoto wrote:
> 
> Hi Mark, OMAP member
> 
> I'm now trying to cleanup snd_soc_card, and noticed that card->pop_time is used
> only from OMAP1 board-ams-delta.
> 
> card->pop_time user drivers are...
> 
> 	> git grep -w -l pop_time sound/soc include/sound
> 	include/sound/soc.h
> (A)	sound/soc/codecs/cx20442.c
> 	sound/soc/soc-card.c
> 	sound/soc/soc-dapm.c
> (B)	sound/soc/ti/ams-delta.c
> 
> Except ASoC framework, pop_time user is only cx20442 (A) / ams-delta (B).
> And board-ams-delta (Z) is using it.
> 
> (Z)	linux/arch/arm/mach-omap1/board-ams-delta.c
> 
> 	static struct platform_device ams_delta_audio_device = {
> (A)		.name   = "ams-delta-audio",
> 	};
> 
> 	static struct platform_device cx20442_codec_device = {
> (B)		.name   = "cx20442-codec",
> 	};
> 
> 	static struct platform_device *ams_delta_devices[] __initdata = {
> 		...
> (A)		&ams_delta_audio_device,
> 		...
> (B)		&cx20442_codec_device,
> 		...
> 	};
> 
> With off-list talk with Mark, this card->pop_time is is much less of a
> problem.

Hmm, are you sure?  IIUC, it's used for a flag in the modem desc for
cx81801, and a bunch of setup seems depending on it, and your second
patch removes the whole of those without alternative.

> So let's remove it. But it needs Acked-by from OMAP1 member.
> I added [RFC] on Subject.

So the actual question is whether the modem is utterly broken for this
hardware or not.  If yes, it'd be a good reason to drop and apply this
cleanup.

But if it's not, we'd need an alternative implementation, e.g. move
the flag and its handling to the modem's own object instead of the
ASoC core, instead.


thanks,

Takashi