Re: [REGRESSION][BISECTED] My audio broke (was: [PATCH 05/27] ALSA: hda: Move controller drivers into sound/hda/controllers directory)

Takashi Iwai
2025-12-09T07:57:48Z

On Sat, 06 Dec 2025 22:39:52 +0100,
Askar Safin wrote:
>
> On Wed, Dec 3, 2025 at 12:42 PM Takashi Iwai <tiwai@suse.de> wrote:
> > A rather hackish fix would be something like below. Instead of
>
> I tested. This patch works. Thank you!
> Tested-by: Askar Safin <safinaskar@gmail.com>

Thanks for testing!

On the second thought, a better fix would be just to change the
default fallback from ANY to LEGACY, so a oneliner change like below.
Could you test it instead of the previous one?

It was set to ANY as we assumed that all drivers should cover the
devices generally, but in the end, SOF or AVS need specific firmware
files, hence it doesn't make sense to bind to them if specific kconfig
is enabled.

Takashi

-- 8< --
--- a/sound/hda/core/intel-dsp-config.c
+++ b/sound/hda/core/intel-dsp-config.c
@@ -718,7 +718,7 @@ int snd_intel_dsp_driver_probe(struct pci_dev *pci)
/* find the configuration for the specific device */
cfg = snd_intel_dsp_find_config(pci, config_table, ARRAY_SIZE(config_table));
if (!cfg)
- return SND_INTEL_DSP_DRIVER_ANY;
+ return SND_INTEL_DSP_DRIVER_LEGACY;

if (cfg->flags & FLAG_SOF) {
if (cfg->flags & FLAG_SOF_ONLY_IF_SOUNDWIRE &&