Re: [PATCH 06/27] ALSA: hda: Move codec drivers into sound/hda/codecs directory

Takashi Iwai
2025-07-14T10:17:28Z

On Mon, 14 Jul 2025 11:35:10 +0200,
Cezary Rojewski wrote:
>
> On 2025-07-14 11:15 AM, Takashi Iwai wrote:
> > On Mon, 14 Jul 2025 11:08:01 +0200,
> > Cezary Rojewski wrote:
> >>
> >> On 2025-07-14 11:04 AM, Takashi Iwai wrote:
> >>> On Mon, 14 Jul 2025 10:57:59 +0200,
> >>> Cezary Rojewski wrote:
> >>>>
> >>>> On 2025-07-09 6:04 PM, Takashi Iwai wrote:
> >>>>> Now move the all remaining codec drivers from sound/pci/hda to
> >>>>> sound/hda/codecs subdirectory. Some drivers are put under the further
> >>>>> vendor subdirectory, and the vendor helper code (*_helper.c) are put
> >>>>> under helpers subdirectory. Also the sub-codec drivers are moved under
> >>>>> a different subdirectory, sound/hda/codecs/sub-codecs, for
> >>>>> distinguishing from the main HD-audio codec drivers.
> >>>>>
> >>>>> The prefix patch_ and hda_ as well as the suffix _helper are dropped
> >>>>> from file names as they are mostly superfluous.
> >>>>>
> >>>>> No functional changes but just file path shuffling.
> >>>>>
> >>>>
> >>>> Path: codecs/side-codecs/ looks wierd. My suggestion is to avoid the
> >>>> repeat and stay with codecs/side/.
> >>>
> >>> Sorry, too late, I already merged the stuff. (And IMO codecs/side
> >>> doesn't sound intuitive.)
> >>>
> >>> Since the directory names are more or less understandable, and Cirrus
> >>> people seem OK with it, so let's leave as is.
> >>
> >> Oh, didn't notice. The series is large and I wasn't expecting it to
> >> get merged that quickly.
> >
> > There should be no much functional changes and the only matter is file
> > name shuffling, and no much regression reports from 0-day, so I
> > decided to merge for 6.17. Then earlier, better.
> >
> > Currently no further code change is planned from my side for 6.17.
> > Also some changes have been queued, they are post 6.17 materials.
> >
> >> Guess no point in reviewing the rest then, thanks for the information!
> >
> > We may still rename if something looks too worrisome, of course.
> > If you have something in mind, let me know.
>
> Thank you. I'll update my tactic a bit - rebase onto the new hda/ and
> reply/send patches separately if anything pops up.
>
> There is a lot to look at and, at the same time it's very encouraging
> to see major work done in hda/ area :)

Great, thanks!

Takashi