Re: [REGRESSION][BISECTED] My audio broke (was: [PATCH 05/27] ALSA: hda: Move controller drivers into sound/hda/controllers directory)

Takashi Iwai
2025-12-09T09:27:06Z

On Tue, 09 Dec 2025 08:57:46 +0100,
Takashi Iwai wrote:
>
> On Sat, 06 Dec 2025 22:39:52 +0100,
> Askar Safin wrote:
> >
> > On Wed, Dec 3, 2025 at 12:42 PM Takashi Iwai <tiwai@suse.de> wrote:
> > > A rather hackish fix would be something like below. Instead of
> >
> > I tested. This patch works. Thank you!
> > Tested-by: Askar Safin <safinaskar@gmail.com>
>
> Thanks for testing!
>
> On the second thought, a better fix would be just to change the
> default fallback from ANY to LEGACY, so a oneliner change like below.
> Could you test it instead of the previous one?
>
> It was set to ANY as we assumed that all drivers should cover the
> devices generally, but in the end, SOF or AVS need specific firmware
> files, hence it doesn't make sense to bind to them if specific kconfig
> is enabled.

The below one is a revised fix, just to be safer in case the legacy
driver is disabled, too. Give it a try.

Takashi

-- 8< --
From: Takashi Iwai <tiwai@suse.de>
Subject: [PATCH] ALSA: hda: intel-dsp-config: Prefer legacy driver as fallback

When config table entries don't match with the device to be probed,
currently we fall back to SND_INTEL_DSP_DRIVER_ANY, which means to
allow any drivers to bind with it.

This was set so with the assumption (or hope) that all controller
drivers should cover the devices generally, but in practice, this
caused a problem as reported recently. Namely, when a specific
kconfig for SOF isn't set for the modern Intel chips like Alderlake,
a wrong driver (AVS) got probed and failed. This is because we have
entries like:

/* Alder Lake / Raptor Lake */
{
.flags = FLAG_SOF | FLAG_SOF_ONLY_IF_DMIC_OR_SOUNDWIRE,
.device = PCI_DEVICE_ID_INTEL_HDA_ADL_S,
},
....

so this entry is effective only when CONFIG_SND_SOC_SOF_ALDERLAKE is
set. If not set, there is no matching entry, hence it returns
SND_INTEL_DSP_DRIVER_ANY as fallback. OTOH, if the kconfig is set, it
explicitly falls back to SND_INTEL_DSP_DRIVER_LEGACY when no DMIC or
SoundWire is found -- that was the working scenario. That being said,
the current setup may be broken for modern Intel chips that are
supposed to work with either SOF or legacy driver when the
corresponding kconfig were missing.

For addressing the problem above, this patch changes the fallback
driver to the legacy driver as much as possible, i.e. return
SND_INTEL_DSP_DRIVER_LEGACY type. When CONFIG_SND_HDA_INTEL is also
off, the fallback is set to SND_INTEL_DSP_DRIVER_ANY type, just to be
sure.

Link: https://lore.kernel.org/all/20251014034156.4480-1-safinaskar@gmail.com/
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
sound/hda/core/intel-dsp-config.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/sound/hda/core/intel-dsp-config.c b/sound/hda/core/intel-dsp-config.c
index c401c0658421..0c25e87408de 100644
--- a/sound/hda/core/intel-dsp-config.c
+++ b/sound/hda/core/intel-dsp-config.c
@@ -718,7 +718,8 @@ int snd_intel_dsp_driver_probe(struct pci_dev *pci)
/* find the configuration for the specific device */
cfg = snd_intel_dsp_find_config(pci, config_table, ARRAY_SIZE(config_table));
if (!cfg)
- return SND_INTEL_DSP_DRIVER_ANY;
+ return IS_ENABLED(CONFIG_SND_HDA_INTEL) ?
+ SND_INTEL_DSP_DRIVER_LEGACY : SND_INTEL_DSP_DRIVER_ANY;

if (cfg->flags & FLAG_SOF) {
if (cfg->flags & FLAG_SOF_ONLY_IF_SOUNDWIRE &&
--
2.52.0