From: Takashi Iwai <tiwai@suse.de>
To: Keane Mbae <keanembae@gmail.com>
Cc: Takashi Iwai <tiwai@suse.com>, Jaroslav Kysela <perex@perex.cz>,
Kailang Yang <kailang@realtek.com>,
Zhang Heng <zhangheng@kylinos.cn>, Eric Naim <dnaim@cachyos.org>,
Damien Dagorn <damien.dagorn29@gmail.com>,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: hda/realtek: Add mic-mute LED quirk for the HP 245 14 inch G10
Date: Sun, 18 Oct 2026 10:35:35 +0200 [thread overview]
Message-ID: <8733u31k4o.wl-tiwai@suse.de> (raw)
In-Reply-To: <20261017095132.20279-1-keanembae@gmail.com>
On Sat, 17 Oct 2026 11:51:32 +0200,
Keane Mbae wrote:
>
> The HP 245 14 inch G10 Notebook PC (codec SSID 103c:8ba4, ALC236) is not
> listed in alc269_fixup_tbl[], so the codec falls back to the vendor-wide
> HP entry (ALC269_FIXUP_HP_MUTE_LED). That entry only registers a speaker
> mute LED (hda::mute); no microphone mute LED class device (hda::micmute)
> is created, so muting the microphone never lights the LED on the F8 key.
>
> On this model the microphone mute LED is wired to COEF 0x35 bits 2-3 (the
> same register as ALC236_FIXUP_HP_MUTE_LED), but with the opposite sense:
> 1 << 2 lights the LED and 2 << 2 turns it off. Setting
> micmute_led_polarity = 1 makes alc_update_coef_led() write the level that
> matches the hardware.
>
> The speaker mute LED (F5) keeps being driven through the HP_Mute_LED DMI
> string, exactly as the current fallback does.
>
> Add ALC236_FIXUP_HP_MUTE_LED_MICMUTE_COEF_INV for 103c:8ba4.
>
> Signed-off-by: Keane Mbae <keanembae@gmail.com>
> Tested-by: Keane Mbae <keanembae@gmail.com>
Applied to for-next branch. Thanks.
Takashi
prev parent reply other threads:[~2026-10-18 8:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-17 9:51 [PATCH] ALSA: hda/realtek: Add mic-mute LED quirk for the HP 245 14 inch G10 Keane Mbae
2026-10-18 8:35 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8733u31k4o.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=damien.dagorn29@gmail.com \
--cc=dnaim@cachyos.org \
--cc=kailang@realtek.com \
--cc=keanembae@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=zhangheng@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox