From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3868527281E for ; Thu, 16 Apr 2026 08:57:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776329860; cv=none; b=n0tweR/DZjI1CqGZDseMCptIuLq5dLB5ZCN/PWmPBc3krOFmGWd/DSFq9D5eZGJxQ6Oy3gtfZTeY9BI6Gs850IsUgHsQQCGuJtB21mXiCj+FdLFMFOrnHmj1CixHNXy7XH3kRoZHF0HwDaRvbYNmus3fI7ry1hRWm5MoXYs2kDI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776329860; c=relaxed/simple; bh=ofvukmhZd/tQ/OgUruA+KBobhi/wYLsOepChT+YCaIw=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=ALNebAyFjZ9/1U0YJQPaFW/bL4+7ShYYa5bJx8a5E8zOaVgd7DXdLeUIpU/JIYyFf+57s+/QpdRyDyLCOPxIaGaXmyj2l3aVOHccYS50CRy53et1D+ok+YcEwhtIl+tPa86FYjKbYwyyISRSYklR9Y8nIWH6m3ecthAJvbzj8os= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=hxILrxRY; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=kDYVhYqs; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=mN0gdmgD; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=iHwYWYML; arc=none smtp.client-ip=195.135.223.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="hxILrxRY"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="kDYVhYqs"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="mN0gdmgD"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="iHwYWYML" Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id DE40C5BD11; Thu, 16 Apr 2026 08:57:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1776329852; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AQvNnGry76qxPYC6clCvGh41W0kGFBVU/d9VjmQrVwc=; b=hxILrxRYIWuKaqr433r6SmPTr1FWPrHFvywEB8kTTGkqwTWBW9zLxrhgL2/Pgk9NSUhLIT XjXP5ZCQi9NcO903Rw0DHozfa9reQvzSNhKGmsjaoOtGDCzdE0XszbuED1o8mtLkZ4MMlF fIHiyUXBJn2Q1vdBg9eG/uNJpnuFbqk= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1776329852; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AQvNnGry76qxPYC6clCvGh41W0kGFBVU/d9VjmQrVwc=; b=kDYVhYqswPmpwf+RtymwAHQ5FehPVHs8UqJlqZb2Nha3o3F6h8usWqhr+g0DQszLzNXkcf jEdiWXM00H2catAw== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1776329851; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AQvNnGry76qxPYC6clCvGh41W0kGFBVU/d9VjmQrVwc=; b=mN0gdmgDUEZfzfC8yh0iwEe24K2LPVpgV7Y4WI19KlnbVdlQYerIsPMV7Jxx1hzbPEd9iB czs9Mi0ZXNV6qppleymCDk13jU3k5OlrxeVs8/8fnV2wkIRL0fxXlehfJmUNmunviPqyq/ s5nqGOzGDDl293LJCqcOsfDb14HzOe8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1776329851; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AQvNnGry76qxPYC6clCvGh41W0kGFBVU/d9VjmQrVwc=; b=iHwYWYMLBqAbiOG7qeE2wgYxcKr/AqDZd+2iVAF5v/yfCceksnDF/YxbjCxRZdfehTmtEC q2ZhiQNqH2SaG8Cw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 8F6034BE97; Thu, 16 Apr 2026 08:57:31 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id PR/SIXuk4GmtSgAAD6G6ig (envelope-from ); Thu, 16 Apr 2026 08:57:31 +0000 Date: Thu, 16 Apr 2026 10:57:31 +0200 Message-ID: <87340vffk4.wl-tiwai@suse.de> From: Takashi Iwai To: =?ISO-8859-1?Q?C=E1ssio?= Gabriel Cc: Takashi Iwai , Jaroslav Kysela , Xi Wang , linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, Takashi Iwai , stable@vger.kernel.org, syzbot+d56178c27a4710960820@syzkaller.appspotmail.com Subject: Re: [PATCH] ALSA: usb-audio: stop parsing UAC2 rates at MAX_NR_RATES In-Reply-To: <20260415-usb-audio-uac2-rate-cap-v1-1-5ecbafc120d8@gmail.com> References: <20260415-usb-audio-uac2-rate-cap-v1-1-5ecbafc120d8@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/30.2 Mule/6.0 Precedence: bulk X-Mailing-List: linux-sound@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit X-Spamd-Result: default: False [-1.80 / 50.00]; BAYES_HAM(-3.00)[99.99%]; SUSPICIOUS_RECIPS(1.50)[]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; TAGGED_RCPT(0.00)[d56178c27a4710960820]; FUZZY_RATELIMITED(0.00)[rspamd.com]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_TLS_ALL(0.00)[]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_TO(0.00)[gmail.com]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_HAS_DN(0.00)[]; FREEMAIL_CC(0.00)[suse.com,perex.cz,gmail.com,vger.kernel.org,suse.de,syzkaller.appspotmail.com]; RCPT_COUNT_SEVEN(0.00)[9]; FROM_EQ_ENVFROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; URIBL_BLOCKED(0.00)[syzkaller.appspot.com:url,suse.de:mid,imap1.dmz-prg2.suse.org:helo,appspotmail.com:email]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,suse.de:mid] X-Spam-Flag: NO X-Spam-Score: -1.80 X-Spam-Level: On Wed, 15 Apr 2026 17:04:53 +0200, Cássio Gabriel wrote: > > parse_uac2_sample_rate_range() caps the number of enumerated > rates at MAX_NR_RATES, but it only breaks out of the current > rate loop. A malformed UAC2 RANGE response with additional > triplets continues parsing the remaining triplets and repeatedly > prints "invalid uac2 rates" while probe still holds > register_mutex. > > Stop the whole parse once the cap is reached and return the > number of rates collected so far. > > Fixes: 4fa0e81b8350 ("ALSA: usb-audio: fix possible hang and overflow in parse_uac2_sample_rate_range()") > Cc: stable@vger.kernel.org > Reported-by: syzbot+d56178c27a4710960820@syzkaller.appspotmail.com > Closes: https://syzkaller.appspot.com/bug?extid=d56178c27a4710960820 > Signed-off-by: Cássio Gabriel Thanks, applied now. Takashi