Linux Sound subsystem development
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Samuel Dionne-Riel <samuel@dionne-riel.com>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] ALSA: hda/realtek: Add quirk for Minisforum V3 SE
Date: Tue, 03 Feb 2026 15:30:45 +0100	[thread overview]
Message-ID: <87343hlx0q.wl-tiwai@suse.de> (raw)
In-Reply-To: <20260203010132.1981419-2-samuel@dionne-riel.com>

On Tue, 03 Feb 2026 02:01:33 +0100,
Samuel Dionne-Riel wrote:
> 
> First, adding a generic quirk for Bass speaker DAC avoidance.
> 
> This pattern (re-routing the bass speakers off of a DAC without volume
> control) seems common enough that having a "model" to match against and
> quickly use to verify may be worthwhile.
> 
> The alc285_fixup_thinkpad_x1_gen7 routing was selected, amongst the
> different options, as it should allow tuning the ratio between both
> speaker set.
> 
> The routing was verified using `hda-verb`, and picking either 0x00 or
> 0x01. Either routing made the volume of the bass speakers controllable.
> 
>     hda-verb /dev/snd/hwC1D0 0x17 SET_CONNECT_SEL 0x01
> 
> This likely will apply for the Minisforum V3, though there isn't a lot
> of information to confirm whether or not the identifiers are the same.
> 
> This was verified on the Minisforum V3 SE, and the root cause (the bass
> speakers routing) was found out by using pink noise, and playing with
> the mixers.
> 
> Signed-off-by: Samuel Dionne-Riel <samuel@dionne-riel.com>
> 
> ---
> 
> Hi!
> 
> > Indeed it looks like that we can cleanup a lot regarding this DAC
> > routing fix-ups.  Though, *_thinkpad_x1_gen7() has more workarounds
> > about the control element renames -- which needs to be verified
> > whether the very same workaround is applicable to other cases.
> 
> The renames were the reason I picked this particular fixup. It matches
> the fact these are distinct speakers, and matches the role.
> 
> > IIUC, this kcontrol names (DAC1/DAC2) match with your device
> > configuration?  Could you give alsa-info.sh output?
> 
> Indeed! Here is the output:
> 
>  - https://alsa-project.org/db/?f=69517ae9d95e21b50eddc64538c7094aaf356a07
> 
> 
> See also v1 for the methodology additional commentary.
>  - https://lore.kernel.org/linux-sound/20260201231216.1655154-1-samuel@dionne-riel.com/
> 
> Changes since v1:
>  - Combined commits
>  - Fixed order of the fixup table
> 
> Thank you for your time!
> 
> Signed-off-by: Samuel Dionne-Riel <samuel@dionne-riel.com>

Now I applied to for-next branch, as it's no urgent fix.
I slightly modified the patch to adapt to the latest tree.


thanks,

Takashi

      reply	other threads:[~2026-02-03 14:30 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-03  1:01 [PATCH v2] ALSA: hda/realtek: Add quirk for Minisforum V3 SE Samuel Dionne-Riel
2026-02-03 14:30 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87343hlx0q.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=samuel@dionne-riel.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox