Re: [PATCH v4 1/2] ALSA: pcm: reinvent the stream synchronization ID API

[Takashi Iwai <tiwai@suse.de>]

On Thu, 13 Jun 2024 14:56:49 +0200,
Takashi Sakamoto wrote:
> 
> Hi,
> 
> On Tue, May 07, 2024 at 03:30:50PM +0200, Jaroslav Kysela wrote:
> > diff --git a/include/uapi/sound/asound.h b/include/uapi/sound/asound.h
> > index 628d46a0da92..c458172b32d5 100644
> > --- a/include/uapi/sound/asound.h
> > +++ b/include/uapi/sound/asound.h
> > @@ -142,7 +142,7 @@ struct snd_hwdep_dsp_image {
> >   *                                                                           *
> >   *****************************************************************************/
> >  
> > -#define SNDRV_PCM_VERSION		SNDRV_PROTOCOL_VERSION(2, 0, 17)
> > +#define SNDRV_PCM_VERSION		SNDRV_PROTOCOL_VERSION(2, 0, 18)
> >  
> >  typedef unsigned long snd_pcm_uframes_t;
> >  typedef signed long snd_pcm_sframes_t;
> > @@ -330,12 +330,6 @@ enum {
> >  #endif
> >  };
> >  
> > -union snd_pcm_sync_id {
> > -	unsigned char id[16];
> > -	unsigned short id16[8];
> > -	unsigned int id32[4];
> > -};
> 
> It can bring FTBFS for any userspace application which uses the
> structure. If getting rid of such public structure, we should have the
> term to deprecate it for a while.

A good point.  We can keep the union definition there but add a
comment that it's deprecated and not actually used in any code.


Takashi